Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6310 - Changing products 'this item has weight' using 'Update Attributes' is not possible #26075

Merged
merged 3 commits into from
Mar 28, 2020
Merged

Fix #6310 - Changing products 'this item has weight' using 'Update Attributes' is not possible #26075

merged 3 commits into from
Mar 28, 2020

Conversation

Bartlomiejsz
Copy link
Contributor

@Bartlomiejsz Bartlomiejsz commented Dec 17, 2019 •
edited by lenaorobei
Loading

Description (*)

This is fix for #6310

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/150

Fixed Issues (if relevant)

  1. Changing products 'this item has weight' using 'Update Attributes' is not possible #6310: Changing products 'this item has weight' using 'Update Attributes' is not possible

Manual testing scenarios (*)

  1. Select a couple of virtual products in the product grid in the backend
  2. Choose 'Update Attributes' in the 'Actions' dropdown
  3. Search for the weight field, you'll find it
  4. Search for the 'Does this has a weight?', you should be able to find it and use to change multiple products type at once

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 17, 2019

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@Bartlomiejsz Bartlomiejsz force-pushed the feature/fix_6310_this_item_has_weight_update_attributes branch 2 times, most recently from 4fb9caf to bfe493b Compare December 18, 2019 11:23
@Bartlomiejsz Bartlomiejsz added Partner: Fast White Cat partners-contribution Pull Request is created by Magento Partner labels Jan 6, 2020
@Bartlomiejsz Bartlomiejsz force-pushed the feature/fix_6310_this_item_has_weight_update_attributes branch from bfe493b to 166c7ac Compare February 10, 2020 14:11
@Bartlomiejsz Bartlomiejsz linked an issue Feb 27, 2020 that may be closed by this pull request
Changing products 'this item has weight' using 'Update Attributes' is not possible #6310
Closed
@Bartlomiejsz Bartlomiejsz force-pushed the feature/fix_6310_this_item_has_weight_update_attributes branch 4 times, most recently from e41e289 to 84efcec Compare February 27, 2020 15:52
@Bartlomiejsz Bartlomiejsz force-pushed the feature/fix_6310_this_item_has_weight_update_attributes branch from 84efcec to 2506c08 Compare February 27, 2020 19:22
@sivaschenko
Copy link
Member

@magento run all tests

@Bartlomiejsz Bartlomiejsz requested a review from hostep March 4, 2020 15:21
lenaorobei
lenaorobei previously approved these changes Mar 19, 2020
View reviewed changes
@ghost ghost assigned lenaorobei Mar 19, 2020
@lenaorobei lenaorobei added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix labels Mar 19, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-7151 has been created to process this Pull Request

@engcom-Bravo engcom-Bravo self-assigned this Mar 20, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-7151 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

@engcom-Echo engcom-Echo self-assigned this Mar 24, 2020
@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

@magento run all tests

engcom-Echo
engcom-Echo reviewed Mar 26, 2020
View reviewed changes
app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Weight.php Outdated
if (!$this->getForm()->getDataObject()->getTypeInstance()->hasWeight()) {
$this->weightSwitcher->setValue(WeightResolver::HAS_NO_WEIGHT);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in this case you need to do the check opposite.

if ($this->getForm()->getDataObject()->getTypeInstance()->hasWeight()) {
$this->weightSwitcher->setValue(WeightResolver::HAS_WEIGHT);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check should be

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right @engcom-Echo, sorry for that. I restored this check

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

Failed functional tests not related to the changes in this PR

@magento-engcom-team magento-engcom-team mentioned this pull request Mar 28, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Mar 28, 2020
@slavvka
ENGCOM-7151: Fix #6310 - Changing products 'this item has weight' usi…
5ef07e5 
…ng 'Update Attributes' is not possible #26075
@magento-engcom-team magento-engcom-team merged commit 782dad8 into magento:2.4-develop Mar 28, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 28, 2020

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Bartlomiejsz Bartlomiejsz deleted the feature/fix_6310_this_item_has_weight_update_attributes branch May 28, 2020 22:24
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Echo engcom-Echo engcom-Echo left review comments

@lenaorobei lenaorobei lenaorobei approved these changes

@akaplya akaplya Awaiting requested review from akaplya

@DrewML DrewML Awaiting requested review from DrewML

@hostep hostep Awaiting requested review from hostep

@engcom-Bravo engcom-Bravo Awaiting requested review from engcom-Bravo

Assignees

@lenaorobei lenaorobei

@engcom-Bravo engcom-Bravo

@engcom-Echo engcom-Echo

Labels
Area: Design/Frontend Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Catalog Partner: Fast White Cat partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing products 'this item has weight' using 'Update Attributes' is not possible
6 participants
@Bartlomiejsz @sivaschenko @magento-engcom-team @engcom-Bravo @engcom-Echo @lenaorobei