Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Msrp] Cover MsrpPriceCalculator by Unit Test #26067

Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 108 additions & 0 deletions app/code/Magento/Msrp/Test/Unit/Pricing/MsrpPriceCalculatorTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,108 @@
<?php
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/

declare(strict_types=1);

namespace Magento\Msrp\Test\Unit\Pricing;

use Magento\Catalog\Model\Product;
use Magento\Catalog\Model\Product\Type as Type;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this alias is relevant :)

Suggested change
use Magento\Catalog\Model\Product\Type as Type;
use Magento\Catalog\Model\Product\Type as ProductType;

use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
use Magento\GroupedProduct\Model\Product\Type\Grouped as GroupedType;
use Magento\Msrp\Pricing\MsrpPriceCalculator;
use Magento\MsrpGroupedProduct\Pricing\MsrpPriceCalculator as MsrpGroupedCalculator;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;

class MsrpPriceCalculatorTest extends TestCase
{
/**
* Test getMrspPriceValue() with the data provider below
*
* @param array $msrpPriceCalculators
* @param Product $productMock
* @param float $expected
* @dataProvider getMsrpPriceValueDataProvider
*/
public function testGetMsrpPriceValue($msrpPriceCalculators, $productMock, $expected)
{
$objectManager = new ObjectManager($this);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the object manager along with testable object initialization to the setUp method. No need to initialize them for each test case triggered.
Thus, it can be also used in further tests if necessary.

$pricing = $objectManager->getObject(
MsrpPriceCalculator::class,
[
'msrpPriceCalculators' => $msrpPriceCalculators
]
);

$this->assertEquals($expected, $pricing->getMsrpPriceValue($productMock));
}

/**
* Data Provider for test getMrspPriceValue()
*
* @return array
*/
public function getMsrpPriceValueDataProvider()
{
return [
'Get Mrsp Price with grouped product and price calculator is also grouped product type' => [
[
[
'productType' => GroupedType::TYPE_CODE,
'priceCalculator' => $this->createPriceCalculatorMock(
MsrpGroupedCalculator::class,
23.50
)
]
],
$this->createProductMock(GroupedType::TYPE_CODE, 0),
23.50
],
'Get Mrsp Price with simple product and price calculator is grouped product type' => [
[
[
'productType' => GroupedType::TYPE_CODE,
'priceCalculator' => $this->createPriceCalculatorMock(
MsrpGroupedCalculator::class,
0
)
]
],
$this->createProductMock(Type::TYPE_SIMPLE, 24.88),
24.88
]
];
}

/**
* Create Price Calculator Mock
*
* @param string $class
* @param float $msrpPriceValue
* @return MockObject
*/
private function createPriceCalculatorMock($class, $msrpPriceValue)
{
$priceCalculatorMock = $this->createMock($class);
$priceCalculatorMock->expects($this->any())->method('getMsrpPriceValue')->willReturn($msrpPriceValue);
return $priceCalculatorMock;
}

/**
* Create Product Mock
*
* @param string $typeId
* @param float $msrp
* @return MockObject
*/
private function createProductMock($typeId, $msrp)
{
$productMock = $this->createPartialMock(Product::class, ['getTypeId', 'getMsrp']);
$productMock->expects($this->any())->method('getTypeId')->willReturn($typeId);
$productMock->expects($this->any())->method('getMsrp')->willReturn($msrp);
return $productMock;
}
}