-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Msrp] Cover MsrpPriceCalculator by Unit Test #26067
Merged
magento-engcom-team
merged 3 commits into
magento:2.4-develop
from
edenduong:2.4-testcover/cover_msrp_price_calculator
Dec 18, 2019
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
108 changes: 108 additions & 0 deletions
108
app/code/Magento/Msrp/Test/Unit/Pricing/MsrpPriceCalculatorTest.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,108 @@ | ||
<?php | ||
/** | ||
* Copyright © Magento, Inc. All rights reserved. | ||
* See COPYING.txt for license details. | ||
*/ | ||
|
||
declare(strict_types=1); | ||
|
||
namespace Magento\Msrp\Test\Unit\Pricing; | ||
|
||
use Magento\Catalog\Model\Product; | ||
use Magento\Catalog\Model\Product\Type as Type; | ||
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager; | ||
use Magento\GroupedProduct\Model\Product\Type\Grouped as GroupedType; | ||
use Magento\Msrp\Pricing\MsrpPriceCalculator; | ||
use Magento\MsrpGroupedProduct\Pricing\MsrpPriceCalculator as MsrpGroupedCalculator; | ||
use PHPUnit\Framework\MockObject\MockObject; | ||
use PHPUnit\Framework\TestCase; | ||
|
||
class MsrpPriceCalculatorTest extends TestCase | ||
{ | ||
/** | ||
* Test getMrspPriceValue() with the data provider below | ||
* | ||
* @param array $msrpPriceCalculators | ||
* @param Product $productMock | ||
* @param float $expected | ||
* @dataProvider getMsrpPriceValueDataProvider | ||
*/ | ||
public function testGetMsrpPriceValue($msrpPriceCalculators, $productMock, $expected) | ||
{ | ||
$objectManager = new ObjectManager($this); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please move the object manager along with testable object initialization to the |
||
$pricing = $objectManager->getObject( | ||
MsrpPriceCalculator::class, | ||
[ | ||
'msrpPriceCalculators' => $msrpPriceCalculators | ||
] | ||
); | ||
|
||
$this->assertEquals($expected, $pricing->getMsrpPriceValue($productMock)); | ||
} | ||
|
||
/** | ||
* Data Provider for test getMrspPriceValue() | ||
* | ||
* @return array | ||
*/ | ||
public function getMsrpPriceValueDataProvider() | ||
{ | ||
return [ | ||
'Get Mrsp Price with grouped product and price calculator is also grouped product type' => [ | ||
[ | ||
[ | ||
'productType' => GroupedType::TYPE_CODE, | ||
'priceCalculator' => $this->createPriceCalculatorMock( | ||
MsrpGroupedCalculator::class, | ||
23.50 | ||
) | ||
] | ||
], | ||
$this->createProductMock(GroupedType::TYPE_CODE, 0), | ||
23.50 | ||
], | ||
'Get Mrsp Price with simple product and price calculator is grouped product type' => [ | ||
[ | ||
[ | ||
'productType' => GroupedType::TYPE_CODE, | ||
'priceCalculator' => $this->createPriceCalculatorMock( | ||
MsrpGroupedCalculator::class, | ||
0 | ||
) | ||
] | ||
], | ||
$this->createProductMock(Type::TYPE_SIMPLE, 24.88), | ||
24.88 | ||
] | ||
]; | ||
} | ||
|
||
/** | ||
* Create Price Calculator Mock | ||
* | ||
* @param string $class | ||
* @param float $msrpPriceValue | ||
* @return MockObject | ||
*/ | ||
private function createPriceCalculatorMock($class, $msrpPriceValue) | ||
{ | ||
$priceCalculatorMock = $this->createMock($class); | ||
$priceCalculatorMock->expects($this->any())->method('getMsrpPriceValue')->willReturn($msrpPriceValue); | ||
return $priceCalculatorMock; | ||
} | ||
|
||
/** | ||
* Create Product Mock | ||
* | ||
* @param string $typeId | ||
* @param float $msrp | ||
* @return MockObject | ||
*/ | ||
private function createProductMock($typeId, $msrp) | ||
{ | ||
$productMock = $this->createPartialMock(Product::class, ['getTypeId', 'getMsrp']); | ||
$productMock->expects($this->any())->method('getTypeId')->willReturn($typeId); | ||
$productMock->expects($this->any())->method('getMsrp')->willReturn($msrp); | ||
return $productMock; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this alias is relevant :)