[Msrp] Cover MsrpPriceCalculator by Unit Test

[edenduong]

Description (*)

Increase Test Coverage by Cover class Magento\Msrp\Pricing\MsrpPriceCalculator

• getMsrpPriceValue with dataset

Fixed Issues (if relevant)

Manual testing scenarios (*)

vendor/bin/phpunit app/code/Magento/Msrp/Test/Unit/Pricing/MsrpPriceCalculatorTest.php

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[dmytro-ch]

I'm not sure this alias is relevant :)

Suggested change

	use Magento\Catalog\Model\Product\Type as Type;
	use Magento\Catalog\Model\Product\Type as ProductType;

[dmytro-ch]

Please move the object manager along with testable object initialization to the setUp method. No need to initialize them for each test case triggered.
Thus, it can be also used in further tests if necessary.

[edenduong]

Hi @dmytro-ch: Thank you for your feedback. I have changed the source code. Please check it again.

Thanks.

[engcom-Delta]

Notice: QA not applicable

[m2-assistant]

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.