Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue 25896: Cannot create folder using only letters #25896 #25943

Conversation

biztech-magento
Copy link

Description (*)

  1. Consistency between message and behavior when creating folder without latin letters while adding folder from CMS page.
    Changed message to => Please rename the folder using only Latin letters, numbers, underscores and dashes.

Fixed Issues (if relevant)

  1. Cannot create folder using only letters #25896: Cannot create folder using only letters

Manual testing scenarios (*)

  1. On CMS edit page open media gallery
  2. Click "Create Folder"
  3. Type in "папка"
  4. Click "OK"

Expected result

  1. Consistency between message and behavior. => Change message to: Please rename the folder using only Latin letters, numbers, underscores and dash

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 7, 2019

Hi @biztech-magento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@krzksz
Copy link
Contributor

krzksz commented Dec 9, 2019

Hello @biztech-magento, thanks for the contribution! Please sign the CLA, otherwise we are not able to process the PR.

@lenaorobei
Copy link
Contributor

Fixed in #25904

@lenaorobei lenaorobei closed this Jan 14, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 14, 2020

Hi @biztech-magento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants