-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve issue 25896: Cannot create folder using only letters #25904
Resolve issue 25896: Cannot create folder using only letters #25904
Conversation
Hi @edenduong. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento give me test instance |
Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you |
Hi @dmytro-ch, here is your new Magento instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like extending the media browser component lib/web/mage/adminhtml/browser.js
(newFolder
function) with frontend validation is complicated. So let's stick to at least proper backend validation messages for now.
@dmytro-ch: I have updated the csv file. You can check it again. Thank you ! |
Hi @dmytro-ch, thank you for the review. |
✔️ QA Passed |
Hi @edenduong, thank you for your contribution! |
Description (*)
Please rename the folder using only Latin letters, numbers, underscores and dashes.
This PR was covered by Unit Test.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Expected result
Please rename the folder using only Latin letters, numbers, underscores and dashes.
Questions or comments
Contribution checklist (*)