Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#25043 - Since 2.3.3 Store logo automatic resize on mobile/smaller displays does not respect aspect ratio #25623

Merged
merged 1 commit into from
Nov 21, 2019
Merged

#25043 - Since 2.3.3 Store logo automatic resize on mobile/smaller displays does not respect aspect ratio #25623

merged 1 commit into from
Nov 21, 2019

Conversation

fabriciosobral
Copy link

@fabriciosobral fabriciosobral commented Nov 16, 2019 •
edited by LucasCalazans
Loading

Description (*)

Fixed resize logo img when mobile resolution

Fixed Issues (if relevant)

#25043: Since 2.3.3 Store logo automatic resize on mobile/smaller displays does not respect aspect ratio

Manual testing scenarios (*)

1- Create a test logo image of size 400x100 pixels
2 - Deploy 2.3-develop
3 - Content->Configuration->Global->Edit->Header->Upload Logo Image
4 - Content->Configuration->Global->Edit->Header->Height = 100
5 - Content->Configuration->Global->Edit->Header->Width = 400
6 - Use browser developer tools to simulate resizing screen to small sizes.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 16, 2019

Hi @fabriciosobral. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@fabriciosobral
Copy link
Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @fabriciosobral. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @fabriciosobral, here is your new Magento instance.
Admin access: https://pr-25623.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@fabriciosobral
Copy link
Author

Tested in instance based on PR changes
image

@fabriciosobral fabriciosobral added the Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release label Nov 16, 2019
@rodrigowebjump
Copy link
Member

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, here is your Magento instance.
Admin access: https://i-25623-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ghost ghost assigned rodrigowebjump Nov 19, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, thank you for the review.
ENGCOM-6298 has been created to process this Pull Request
✳️ @rodrigowebjump, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa self-assigned this Nov 20, 2019
@engcom-Alfa engcom-Alfa added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Nov 20, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Nov 20, 2019
@ghost ghost added the Progress: accept label Nov 20, 2019
@ihor-sviziev ihor-sviziev mentioned this pull request Nov 20, 2019
Closed
4 tasks
@VladimirZaets VladimirZaets mentioned this pull request Nov 21, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Nov 21, 2019
@VladimirZaets
ENGCOM-6298: #25043 - Since 2.3.3 Store logo automatic resize on mobi…
7b1f571 
…le/smaller displays does not respect aspect ratio #25623
@magento-engcom-team magento-engcom-team merged commit d0167a0 into magento:2.3-develop Nov 21, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 21, 2019

Hi @fabriciosobral, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzksz krzksz krzksz approved these changes

@rodrigowebjump rodrigowebjump rodrigowebjump approved these changes

Assignees

@rodrigowebjump rodrigowebjump

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Partner: Webjump partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3 Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
Release: 2.3.5
Development

Successfully merging this pull request may close these issues.
6 participants
@fabriciosobral @magento-engcom-team @rodrigowebjump @engcom-Alfa @krzksz @engcom-Foxtrot