Since 2.3.3 Store logo automatic resize on mobile/smaller displays does not respect aspect ratio #25043

gwharton · 2019-10-14T11:43:03Z

Preconditions (*)

Magento 2.3.3+

Steps to reproduce (*)

Create a test logo image of size 400x100 pixels
Deploy 2.3-develop
Content->Configuration->Global->Edit->Header->Upload Logo Image
Content->Configuration->Global->Edit->Header->Height = 100
Content->Configuration->Global->Edit->Header->Width = 400
Use browser developer tools to simulate resizing screen to small sizes.

Expected result (*)

Header image aspect ratio is maintained when window is resized.
This screenshot is running on 2.3.2

Actual result (*)

Header image does not respect aspect ratio and is resized incorrectly.
This screenshot is running on 2.3-develop

m2-assistant · 2019-10-14T11:43:05Z

Hi @gwharton. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@gwharton do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

yes
no

Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant · 2019-10-14T11:45:24Z

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
5. Add label Issue: Confirmed once verification is complete.
6. Make sure that automatic system confirms that report has been added to the backlog.

magento-engcom-team · 2019-10-14T14:28:54Z

✅ Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MC-21776 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

m2-assistant · 2019-10-15T04:19:34Z

Hi @webkul-ramakant. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
3. If the issue is not relevant or is not reproducible any more, feel free to close it.

Join Magento Community Engineering Slack and ask your questions in #github channel.

gwharton · 2019-10-15T12:21:35Z

Infact, this looks like it affects many more images than just the logo. Any image that is too large in width to fit into the parent container is shrunk in width to fit, but not in height resulting in skewed aspect ratios everywhere.

m2-assistant · 2019-10-15T12:29:43Z

Hi @vivekkumar-webkul. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
3. If the issue is not relevant or is not reproducible any more, feel free to close it.

Join Magento Community Engineering Slack and ask your questions in #github channel.

gwharton · 2019-10-15T12:50:12Z

Seems related to the addition of max-height:100% and the removal of height:auto from the img tag in the luma style.

extremeskillz · 2019-10-15T23:30:00Z

I can confirm this on my install today.
Interestingly enough 2.3.3 fixed an issue I was having in 2.3.2 where the mobile version wouldn't scale on mobile browsers. 2.3.3 is now doing that properly but the height isn't adjusting. See attached screenshot.

fabriciosobral · 2019-11-14T15:03:07Z

Can I work on this? If yes, please assign

m2-assistant · 2019-11-15T22:37:47Z

Hi @fabriciosobral. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
3. If the issue is not relevant or is not reproducible any more, feel free to close it.

Join Magento Community Engineering Slack and ask your questions in #github channel.

fabriciosobral · 2019-11-15T22:38:15Z

I am working on this

fabriciosobral · 2019-11-16T02:21:19Z

@magento give me 2.3-develop instance

magento-engcom-team · 2019-11-16T02:21:23Z

Hi @fabriciosobral. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team · 2019-11-16T02:21:59Z

Hi @fabriciosobral, here is your Magento instance.
Admin access: https://i-25043-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

VladimirZaets · 2019-11-21T04:43:54Z

Hi @gwharton. Thank you for your report.
The issue has been fixed in #25623 by @fabriciosobral in 2.3-develop branch
Related commit(s):

d0167a0029358c0324abdf3a8f6313bf66cff2ff

The fix will be available with the upcoming 2.3.5 release.

…le/smaller displays does not respect aspect ratio #25623 - Merge Pull Request #25623 from fabriciosobral/magento2:issue-25043-logo-automatic-resize - Merged commits: 1. d0167a0

…le/smaller displays does not respect aspect ratio #25623

magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Oct 14, 2019

shikhamis11 self-assigned this Oct 14, 2019

shikhamis11 added Component: Backend Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Oct 14, 2019

ghost unassigned shikhamis11 Oct 14, 2019

magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 14, 2019

dynamicswebkul self-assigned this Oct 15, 2019

dynamicswebkul removed their assignment Oct 15, 2019

vivekkumar945744 self-assigned this Oct 15, 2019

ghost unassigned vivekkumar945744 Nov 9, 2019

fabriciosobral self-assigned this Nov 15, 2019

fabriciosobral added the Area: Frontend label Nov 16, 2019

fabriciosobral mentioned this issue Nov 16, 2019

#25043 - Since 2.3.3 Store logo automatic resize on mobile/smaller displays does not respect aspect ratio #25623

Merged

4 tasks

abrarpathan19 mentioned this issue Nov 20, 2019

All images height issue #25665

Closed

4 tasks

ghost assigned abrarpathan19 Nov 20, 2019

ghost unassigned abrarpathan19 Nov 20, 2019

VladimirZaets added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Nov 21, 2019

VladimirZaets closed this as completed Nov 21, 2019

magento-engcom-team pushed a commit that referenced this issue Nov 21, 2019

ENGCOM-6298: #25043 - Since 2.3.3 Store logo automatic resize on mobi…

7b1f571

…le/smaller displays does not respect aspect ratio #25623

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Since 2.3.3 Store logo automatic resize on mobile/smaller displays does not respect aspect ratio #25043

Since 2.3.3 Store logo automatic resize on mobile/smaller displays does not respect aspect ratio #25043

gwharton commented Oct 14, 2019 •

edited

Loading

m2-assistant bot commented Oct 14, 2019 •

edited by gwharton

Loading

m2-assistant bot commented Oct 14, 2019

magento-engcom-team commented Oct 14, 2019

m2-assistant bot commented Oct 15, 2019

gwharton commented Oct 15, 2019 •

edited

Loading

m2-assistant bot commented Oct 15, 2019

gwharton commented Oct 15, 2019

extremeskillz commented Oct 15, 2019

fabriciosobral commented Nov 14, 2019

m2-assistant bot commented Nov 15, 2019

fabriciosobral commented Nov 15, 2019

fabriciosobral commented Nov 16, 2019

magento-engcom-team commented Nov 16, 2019

magento-engcom-team commented Nov 16, 2019

VladimirZaets commented Nov 21, 2019

Since 2.3.3 Store logo automatic resize on mobile/smaller displays does not respect aspect ratio #25043

Since 2.3.3 Store logo automatic resize on mobile/smaller displays does not respect aspect ratio #25043

Comments

gwharton commented Oct 14, 2019 • edited Loading

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

Actual result (*)

m2-assistant bot commented Oct 14, 2019 • edited by gwharton Loading

m2-assistant bot commented Oct 14, 2019

magento-engcom-team commented Oct 14, 2019

m2-assistant bot commented Oct 15, 2019

gwharton commented Oct 15, 2019 • edited Loading

m2-assistant bot commented Oct 15, 2019

gwharton commented Oct 15, 2019

extremeskillz commented Oct 15, 2019

fabriciosobral commented Nov 14, 2019

m2-assistant bot commented Nov 15, 2019

fabriciosobral commented Nov 15, 2019

fabriciosobral commented Nov 16, 2019

magento-engcom-team commented Nov 16, 2019

magento-engcom-team commented Nov 16, 2019

VladimirZaets commented Nov 21, 2019

gwharton commented Oct 14, 2019 •

edited

Loading

m2-assistant bot commented Oct 14, 2019 •

edited by gwharton

Loading

gwharton commented Oct 15, 2019 •

edited

Loading