Add Cron Jobs names to New Relic transactions #23784
Conversation
|
Hi @lbajsarowicz. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
magento-engcom-team
added
Component: Cron
Component: NewRelicReporting
Release Line: 2.3
Partner: Strix
partners-contribution
ghost
assigned 
|
Hi @pmclain, thank you for the review.
|
pmclain
added
Award: bug fix
Auto-Tests: Not Covered
|
cc @mpchadwick |
| /** | ||
| * Cron Job name pattern for Profiling | ||
| */ | ||
| const CRON_TIMERID = 'job %s'; |
There was a problem hiding this comment.
Please, make const private
| * @return void | ||
| */ | ||
| private function stopProfiling() | ||
| private function stopProfiling(string $jobName = '') |
There was a problem hiding this comment.
I can't find the case when $jobName may be optional.
| * @return void | ||
| */ | ||
| private function startProfiling() | ||
| private function startProfiling(string $jobName = '') |
There was a problem hiding this comment.
I can't find the case when $jobName may be optional.
| */ | ||
| class StatPlugin | ||
| { | ||
| const TIMER_NAME_CRON_PREFIX = 'job'; |
| * @param bool $ignore | ||
| * @return void | ||
| */ | ||
| public function endTransaction($ignore = false) |
There was a problem hiding this comment.
Unfortunately, we are not allowed to add new public methods according to our Backward Compatible Development Guide
|
Added ugly workaround, checking if any transaction is open - if so, close it with private method. Everything should be removed with 2.4-dev |
sidolov
removed
the
Auto-Tests: Not Covered
sidolov
added
the
Auto-Tests: Covered
|
Turning down the issue to fix it differently, cleaner way. |
|
Hi @lbajsarowicz, thank you for your contribution! |
Description (*)
Feature: Add missing transaction names for Cron Jobs in New Relic reports
I've modified private methods, as this is not backward incompatible.
Fixed Issues (if relevant)
Manual testing scenarios (*)
bin/magento cron:runContribution checklist (*)