#22047: Magento CRON Job Names are missing in NewRelic: Transactions FIX

[PiotrSiejczuk]

Description (*)

Magento CRON Job Names are missing in NewRelic: Transactions Names - This Pull Request Fixes it as per Detailed Description below

Fixed Issues (if relevant)

1. Magento CRON Job Names are missing in NewRelic: "Transaction Names" #22047: Magento CRON Job Names are missing in NewRelic: "Transaction Names"

Manual testing scenarios (*)

1. Running Magento 2.3.x
2. Correctly Configured CRON Jobs
3. Schedule Cron Job Execution
4. Wait for any Cron Job Execution
5. See Cron Jobs Executed with proper Transaction Names in NewRelic Transaction traces:

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[m2-assistant]

Hi @PiotrSiejczuk. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-cicd2]

All committers have signed the CLA.

[sivaschenko]

Hi @PiotrSiejczuk , thanks for the pull request!

Magento_Cron module should not be aware of New Relic, can you please move the implementation to Magento_NewRelicReporting module.

Also, please avoid adding static functions and ensure method/constant/properties visibility is set to private where possible

[PiotrSiejczuk]

@sivaschenko thank you for your feedback. I have discussed this topic together with @lbajsarowicz. The idea is that he is going to extend his changes within: PR: #22059 to incorporate mine by doing that within NewRelic_Reporting Module

If for some reason that is not going to happen I will refactor my PR to improve logic and quality of the proposed changes

[sidolov]

Hi @PiotrSiejczuk , I'm closing this PR since #22059 was merged recently.
Thank you for your contribution!

[m2-assistant]

Hi @PiotrSiejczuk, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[PiotrSiejczuk]

Hi @sidolov, thank you for your information. Although commits from @lbajsarowicz are not addressing the whole scope of the reported issue. It is perfect that CLI CRON commands are being correctly Tracked @ NewRelic now. Although it is not tracking correctly ATOMIC Transactions executed within standard CRON execution. That being said: this ticket should not be CLOSED as the FIX is not addressing the whole scope of the ISSUE described initially