-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all marketing get params on Varnish to minimize the cache objects (added facebook and bronto parameter) #22226
Conversation
…cts (added facebook parameter)
Hi @lfluvisotto. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @ihor-sviziev, thank you for the review. |
✔️ QA passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please exclude Bronto email params (_bta_tid, _bta_c) as well? Appreciate it!
…cts (added bronto parameter)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
Hi @kalpmehta, thank you for the review. |
✔️ QA passed |
Hi @lfluvisotto, thank you for your contribution! |
…he cache objects (added facebook parameter) #22226
Description (*)
Right now the same page with different UTM, mailchimp, other marketing params is NOT cached. It leads to higher load than expected.
This PR removes marketing get params from URL, as result - increased returned results from cache -> Lower load on servers.
Related: https://stackoverflow.com/questions/45298422/seo-and-stripping-utm-parameters-with-varnish
Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
Contribution checklist (*)