-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Remove all marketing get params on Varnish to minimize the cache objects #21819
[Backport] Remove all marketing get params on Varnish to minimize the cache objects #21819
Conversation
Hi @ihor-sviziev. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @josefbehr, thank you for the review. |
✔️ QA passed |
@ihor-sviziev @josefbehr I will put this pull request on hold, let's review it after the original pull request is merged (as code can be updated during processing activities) |
@ihor-sviziev how about also add fbclid (facebook parameter) in a new pull request ? |
Hi @lfluvisotto, Could you create PR with changes you suggested? |
@ihor-sviziev please check it #22226 |
Hi @ihor-sviziev, thank you for your contribution! |
… minimize the cache objects #21819
Original Pull Request
#21818
Description (*)
Right now the same page with different UTM, mailchimp, other marketing params is NOT cached. It leads to higher load than expected.
This PR removes marketing get params from URL, as result - increased returned results from cache -> Lower load on servers.
Related: https://stackoverflow.com/questions/45298422/seo-and-stripping-utm-parameters-with-varnish
Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
Contribution checklist (*)