Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] #21734 Error in JS validation rule #21813

Merged
merged 2 commits into from
Apr 4, 2019

Conversation

kisroman
Copy link
Contributor

@kisroman kisroman commented Mar 18, 2019

Original PR: #21776

Description (*)

Bug in "validate-per-page-value-list" validation.

Fixed Issues (if relevant)

  1. Error in JS validation rule #21734

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @kisroman. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmytro-ch dmytro-ch changed the title #21734 Error in JS validation rule [Backport] #21734 Error in JS validation rule Mar 26, 2019
@dmytro-ch dmytro-ch self-requested a review March 29, 2019 18:55
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4610 has been created to process this Pull Request

@soleksii
Copy link

soleksii commented Apr 2, 2019

✔️ QA Passed

Result:

after

@m2-assistant
Copy link

m2-assistant bot commented Apr 4, 2019

Hi @kisroman, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants