Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in JS validation rule #21734

Closed
staradzinau opened this issue Mar 13, 2019 · 11 comments
Closed

Error in JS validation rule #21734

staradzinau opened this issue Mar 13, 2019 · 11 comments
Assignees
Labels
Component: Ui Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@staradzinau
Copy link

staradzinau commented Mar 13, 2019

Preconditions (*)

  1. Magento 2.1.x | 2.2.x | 2.3.x

Steps to reproduce (*)

  1. Open any UI form component XML file
  2. Add to any input field following validation rule: validate-per-page-value-list
  3. Set some value to the input from the previous step

Expected result (*)

  1. Validation works correctly

Actual result (*)

  1. Validation is failed for every non-empty value, even valid (for example "10,20")

Additional Information

Please, check corresponding JS file: https://github.com/magento/magento2/blob/2.3/app/code/Magento/Ui/view/base/web/js/lib/validation/rules.js, line 897
When value is not empty, that validation rule will always return false

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 13, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Mar 13, 2019

Hi @avgust1111. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@avgust1111 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@kisroman kisroman self-assigned this Mar 15, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Mar 15, 2019

Hi @kisroman. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@kisroman
Copy link
Contributor

@avgust1111 I can not reproduce this issue. Fresh Magento 2.3 installation. Go to Stores -> Configuration -> Catalog -> Catalog -> Storefront -> Products per Page on Grid Allowed Values - enter some valid value and press save - save is successful for me.

@staradzinau
Copy link
Author

@kisroman You can't reproduce the issue, because that kind of validation is not supported on the Stores -> Configuration pages.
Please, add specified validation rule (validate-per-page-value-list) to any input, which is declared within backend UI component XML to reproduce the issue

@kisroman
Copy link
Contributor

@avgust1111 thank you for additional information. I am able to reproduce it now.

@kisroman kisroman added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Mar 15, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Mar 15, 2019

@kisroman Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess
  • Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Mar 15, 2019
@kisroman kisroman added Component: Ui Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Mar 15, 2019
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Mar 15, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @kisroman
Thank you for verifying the issue! 👍 Your confirmation will help us to acknowledge and process this report.

kisroman added a commit to kisroman/magento2 that referenced this issue Mar 15, 2019
kisroman added a commit to kisroman/magento2 that referenced this issue Mar 18, 2019
@kisroman kisroman self-assigned this Mar 18, 2019
@magento-engcom-team
Copy link
Contributor

Hi @kisroman. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

kisroman added a commit to kisroman/magento2 that referenced this issue Mar 19, 2019
kisroman added a commit to kisroman/magento2 that referenced this issue Mar 19, 2019
@shikhamis11 shikhamis11 added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Mar 28, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98942, MAGETWO-98943 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Mar 28, 2019
@shikhamis11 shikhamis11 added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Mar 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @avgust1111. Thank you for your report.
The issue has been fixed in #21776 by @kisroman in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 29, 2019
magento-engcom-team added a commit that referenced this issue Mar 29, 2019
 - Merge Pull Request #21776 from kisroman/magento2:21734
 - Merged commits:
   1. c8ed1e8
   2. b030da0
amol2jcommerce pushed a commit to amol2jcommerce/magento2 that referenced this issue Mar 29, 2019
amol2jcommerce pushed a commit to amol2jcommerce/magento2 that referenced this issue Mar 29, 2019
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Apr 4, 2019
@magento-engcom-team
Copy link
Contributor

Hi @avgust1111. Thank you for your report.
The issue has been fixed in #21813 by @kisroman in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

magento-engcom-team added a commit that referenced this issue Apr 4, 2019
 - Merge Pull Request #21813 from kisroman/magento2:21734-2.2
 - Merged commits:
   1. 6bb24ef
   2. 0add8b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Ui Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

4 participants