Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#14958: Add missing foreign key #14997

Closed
wants to merge 4 commits into from
Closed

#14958: Add missing foreign key #14997

wants to merge 4 commits into from

Conversation

tim-bezhashvyly
Copy link

@tim-bezhashvyly tim-bezhashvyly commented May 4, 2018

sale_sequence_meta and sales_sequence_profile records are now removed upon store deletion.

Description

Adds missing foreign key

Fixed Issues (if relevant)

  1. sale_sequence_* records are not removed on store view deletion #14958: sale_sequence_* records are not removed on store deletion

Manual testing scenarios

  1. Delete a store view
  2. Check that records with deleted store view ID are deleted from sale_sequence_meta table

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

@tim-bezhashvyly thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@sidolov sidolov self-assigned this May 5, 2018
@sidolov
Copy link
Contributor

sidolov commented May 5, 2018

Hi @tim-bezhashvyly , unfortunately, your solution not compatible with our
Split database performance solution
. In the case when sales tables will be in a separate database created foreign key for store table will be broken. The possible way to fix this issue may be the new plugin that will be triggered after the store has been removed.

@sidolov
Copy link
Contributor

sidolov commented May 20, 2018

@tim-bezhashvyly , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration!

@sidolov sidolov closed this May 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants