Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sale_sequence_* records are not removed on store view deletion #14958

Closed
tim-bezhashvyly opened this issue May 3, 2018 · 4 comments
Closed

sale_sequence_* records are not removed on store view deletion #14958

tim-bezhashvyly opened this issue May 3, 2018 · 4 comments
Assignees
@Bartlomiejsz
Labels
Component: Store Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@tim-bezhashvyly
Copy link

tim-bezhashvyly commented May 3, 2018 •
edited by ghost
Loading

sale_sequence_meta and sales_sequence_profile records are not removed upon store deletion.

Preconditions

  1. Magento 2.2

Steps to reproduce

  1. Delete existing store view

Expected result

  1. sale_sequence_meta and sales_sequence_profile contain no records referencing to removed store

Actual result

  1. sale_sequence_meta and sales_sequence_profile do contain records referencing to removed store
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 3, 2018
@tim-bezhashvyly tim-bezhashvyly mentioned this issue May 4, 2018
Closed
4 tasks
@ghost ghost self-assigned this Jul 12, 2018
@ghost ghost changed the title sale_sequence_* records are not removed on store deletion sale_sequence_* records are not removed on store view deletion Jul 12, 2018
@ghost ghost added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: Store labels Jul 12, 2018
@ghost
Copy link

ghost commented Jul 12, 2018

@tim-bezhashvyly, thank you for your report.
We've acknowledged the issue and added to our backlog.

@ghost ghost removed their assignment Jul 13, 2018
@benjamin-volle benjamin-volle mentioned this issue Oct 8, 2018
Closed
4 tasks
@Bartlomiejsz Bartlomiejsz self-assigned this Apr 12, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 12, 2019

Hi @Bartlomiejsz. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Apr 12, 2019
@Bartlomiejsz
Fix magento#14958 - remove sales sequence data on store view delete
8529467
@Bartlomiejsz Bartlomiejsz mentioned this issue Apr 12, 2019
Merged
4 tasks
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Apr 12, 2019
@Bartlomiejsz
Fix magento#14958 - add unit tests
4c4ae53
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Apr 12, 2019
@Bartlomiejsz
FIx magento#14958 - add last unit test
774d40f
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Apr 12, 2019
@Bartlomiejsz
FIx magento#14958 - fix integration tests
8dab9d7
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Apr 15, 2019
@Bartlomiejsz
Revert "FIx magento#14958 - fix integration tests"
4385c2f 
This reverts commit 8dab9d7.
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Apr 15, 2019
@Bartlomiejsz
Revert "FIx magento#14958 - add last unit test"
78bfbc8 
This reverts commit 774d40f.
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Apr 15, 2019
@Bartlomiejsz
Fix magento#14958 - move sales sequence removal to external class
3ff5c06
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Apr 15, 2019
@Bartlomiejsz
Fix magento#14958 - change fields visibility
85b0730
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Apr 16, 2019
@Bartlomiejsz
Fix magento#14958 - declare dependency on Magento_Store
309a25f
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Jun 4, 2019
@Bartlomiejsz
Fix magento#14958 - apply requested changes
328bc51
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Jun 4, 2019
@Bartlomiejsz
Fix magento#14958 - add declare strict_types
7c078cf
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Jun 7, 2019
@Bartlomiejsz
Fix magento#14958 - move two methods from resource models to private …
76b2085 
…methods of DeleteByStore
@magento-engcom-team magento-engcom-team removed the Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release label Jun 20, 2019
@magento-engcom-team
Copy link
Contributor

Hi @llzard, @Bartlomiejsz.

Thank you for your report and collaboration!

The related internal Jira ticket MAGETWO-93931 was closed as non-reproducible in 2.2.x.
It means that Magento team either unable to reproduce this issue using provided Steps to Reproduce from the Description section on clean or the issue has been already fixed in the scope of other tasks.

But if you still run into this problem please update or provide additional information/steps/preconditions in the Description section and reopen this issue.

@magento-engcom-team magento-engcom-team added the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Jun 20, 2019
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Aug 13, 2019
@Bartlomiejsz
Fix magento#14958 - remove requirement of magento/module-store
11f013c
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Aug 14, 2019
@Bartlomiejsz
fix magento#14958 - fix static check
68d1bed
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Feb 21, 2020
@magento-engcom-team
Copy link
Contributor

Hi @llzard. Thank you for your report.
The issue has been fixed in #22296 by @Bartlomiejsz in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

magento-engcom-team added a commit that referenced this issue Feb 21, 2020
@magento-engcom-team
ENGCOM-4781: Fix #14958 - remove sales sequence data on store view de…
7d14004 
…lete #22296

 - Merge Pull Request #22296 from Bartlomiejsz/magento2:feature/fix_14958_sales_sequence_removal
 - Merged commits:
   1. 8529467
   2. 4c4ae53
   3. 774d40f
   4. 8dab9d7
   5. 4385c2f
   6. 78bfbc8
   7. 3ff5c06
   8. 85b0730
   9. 309a25f
   10. c83a283
   11. 328bc51
   12. 7c078cf
   13. 76b2085
   14. 11f013c
   15. 68d1bed
   16. 48f213d
   17. 6458cc8
   18. 94b6a17
   19. f894321
magento-engcom-team pushed a commit that referenced this issue Feb 21, 2020
@VladimirZaets
ENGCOM-4781: Fix #14958 - remove sales sequence data on store view de…
897c2dd 
…lete #22296
This was referenced May 9, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bartlomiejsz Bartlomiejsz

Labels
Component: Store Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tim-bezhashvyly @Bartlomiejsz @magento-engcom-team