-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK] Updated user.ini according to Magento DevDocs #11734
[TASK] Updated user.ini according to Magento DevDocs #11734
Conversation
Minimum required memory limit can be found here: http://devdocs.magento.com/guides/v2.2/install-gde/prereq/php-settings.html Troubleshooting doc is wrong about Please always start your contributions from default repo branch, According to my understanding all occurrences of |
@orlangur thank you for your feedback I immediately applied your feedback. Next time I will create a pull request first for the base branch |
Great! Thanks for collaboration. Let me clarify the thing regarding target branch. You need to create a clean branch based on freshest All occurrences may be found with Ctrl+Shift+F in PhpStorm or via Here we need to change condition also:
Please make changes as a single clean commit. If you need any assistance with |
b65e0c1
to
8e00d3d
Compare
8e00d3d
to
973986c
Compare
@orlangur I think it is correct now. Thanks for the feedback and quick replies! If it is accepted I will also backport it to 2.1 and forward for 2.3 |
@lewisvoncken almost correct :) |
973986c
to
45648e4
Compare
@orlangur I searched for 768M but I have updated it in the same commit to keep the pull request clean |
Thanks, I mentioned this condition in "Here we need to change condition also:", remarked it accidentally. |
[EngCom] Public Pull Requests - 2.2-develop - MAGETWO-82724 Allow coupon code with special charater to be applied to order in checkout #11710 - MAGETWO-82675 Add a health check to the NGINX configuration sample #11690 - MAGETWO-82562 Coupon codes not showing in invoice #11635 - MAGETWO-82535 Fixed ability to set field config from layout xml #11302 [backport 2.2] #11643 - MAGETWO-81146 Fixing #10275 keyboard submit of adminhtml suggest form. #11250 - MAGETWO-82761 [Backport 2.2-develop] Dashboard Fix Y Axis for range #11751 - MAGETWO-82748 Fix Notice: freePackageValue is undefined #11720 - MAGETWO-82747 [TASK] Updated user.ini according to Magento DevDocs #11734 - MAGETWO-82537 MAGETWO-81311: Check the length of the array before attempting to sli… #11637 - MAGETWO-81970 Add missing translations in Magento_UI #11440 - MAGETWO-81904 FIX #11022 in 2.2-develop: Filter Groups of search criteria parameter have not been included for further processing #11421 - MAGETWO-82179 Fix Filter Customer Report Review 2.2-develop [Backport] #11522
Just found out that Magento was recommending 756M as PHP memory limit. Can I ask you why is that? Why not 768? 756 isn't a power of 2, so it really seems weird. |
@YannBergonzat,
Looks like just an empirical number as to me. Probably was |
Description
The Magento DevDocs recommend to set the memory_limit to 1G or at least 2G for debugging.
http://devdocs.magento.com/guides/v2.2/install-gde/trouble/php/tshoot_php-set.html
Fixed Issues (if relevant)
Contribution checklist