Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.2-develop] Fix Filter Customer Report Review #11522

Merged
merged 6 commits into from
Oct 24, 2017
Merged

[Backport 2.2-develop] Fix Filter Customer Report Review #11522

merged 6 commits into from
Oct 24, 2017

Conversation

osrecio
Copy link
Member

@osrecio osrecio commented Oct 17, 2017

Remove where part from SelectCountSql when grid is filtered

Description

When customer is filtered in Reports -> Review -> By Customer, Grid tries to get number of rows but how you add a custom name that concats customer.firstname and customer.lastname and you need remove where from SelectCountSql

Fixed Issues (if relevant)

  1. Customer review report search Bug in 2.1.x, 2.2 #10301: Customer review report search Bug in 2.1.x, 2.2

Manual testing scenarios

  1. Go to Admin
  2. Reports -> Review -> By Customer
  3. Filter customer

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@osrecio osrecio changed the title Filter Customer Report Review 2.2-develop [Backport] Fix Filter Customer Report Review 2.2-develop [Backport] Oct 17, 2017
@ishakhsuvarov ishakhsuvarov self-assigned this Oct 18, 2017
@ishakhsuvarov ishakhsuvarov added this to the October 2017 milestone Oct 18, 2017
@ishakhsuvarov ishakhsuvarov added Release Line: 2.2 2.2.x bug report Component: Customer Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 18, 2017
@osrecio
Copy link
Member Author

osrecio commented Oct 20, 2017

@ishakhsuvarov Added test to test functionality of getSelectCountSql

@osrecio osrecio changed the title Fix Filter Customer Report Review 2.2-develop [Backport] [Backport 2.2-develop] Fix Filter Customer Report Review Oct 20, 2017
ishakhsuvarov added a commit to osrecio/magento2 that referenced this pull request Oct 24, 2017
@ishakhsuvarov
magento#11522: Fix Filter Customer Report Review
306b9c8 
 - Integration test updated
@okorshenko okorshenko merged commit 02f9bd5 into magento:2.2-develop Oct 24, 2017
okorshenko pushed a commit that referenced this pull request Oct 24, 2017
MAGETWO-82179: Fix Filter Customer Report Review 2.2-develop [Backport]
6addbee 
#11522
AntonEvers pushed a commit to AntonEvers/magento2 that referenced this pull request Oct 26, 2017
Merge remote-tracking branch 'upstream/2.3-develop' into ip-ranges
3a4c2b4 
* upstream/2.3-develop: (37 commits)
  MAGETWO-81033: Create GraphQL single product fetch endpoint  - Address static failure
  MAGETWO-81033: Remove unnecessary classes
  MAGETWO-81033: Create GraphQL endpoint for fetching single product  - Adds functional tests, fixtures, and client  - Adds support for simple and configurable product
  magento#11524: Fix Filter Customer Report Review  - Integration test updated
  MAGETWO-82561: [TASK] Moved Customer Groups Menu Item from Other settings to Customers magento#11652
  MQE-478: Deliver Pangolins Sprint 11
  MQE-478: Deliver Pangolins Sprint 11
  MQE-478: Deliver Pangolins Sprint 11
  magento#11522: Fix Filter Customer Report Review  - Integration test updated
  magento#11524: Fix Filter Customer Report Review  - Integration test added
  Fix Magento/Backend/Block/Media/Uploader.php getConfigJson() method, using undefined class property _coreData
  MAGETWO-77673: <![CDATA[]]>in system.xml translate phrase not work, if comment starts from new line[port from 2.2-develop].
  MQE-478: Deliver Pangolins Sprint 11
  MQE-440: metadata changes for path parameters bug fix.
  MQE-237: [Generator] Add before and after logic to suites
  MQE-394: Pre-Install Script
  MQE-440: Added configurable product related metadata, data, and a sample test.
  MQE-429: Added a sample test to perform api PUT request.
  MQE-453: [DevOps] Add optional arg for consolidated test run
  MQE-345: [DevOps] [Customizability] Create suite schema declaration and supporting interpretation
  ...
magento-team pushed a commit that referenced this pull request Oct 26, 2017
@ishakhsuvarov
MAGETWO-82179: Fix Filter Customer Report Review 2.2-develop [Backport]
30746ae 
#11522
magento-team pushed a commit that referenced this pull request Oct 26, 2017
@ishakhsuvarov
Merge pull request #1625 from magento-engcom/2.2-develop-prs
04140ba 
[EngCom] Public Pull Requests - 2.2-develop
 - MAGETWO-82724 Allow coupon code with special charater to be applied to order in checkout #11710
 - MAGETWO-82675 Add a health check to the NGINX configuration sample #11690
 - MAGETWO-82562 Coupon codes not showing in invoice #11635
 - MAGETWO-82535 Fixed ability to set field config from layout xml #11302 [backport 2.2] #11643
 - MAGETWO-81146 Fixing #10275 keyboard submit of adminhtml suggest form. #11250
 - MAGETWO-82761 [Backport 2.2-develop] Dashboard Fix Y Axis for range #11751
 - MAGETWO-82748 Fix Notice: freePackageValue is undefined #11720
 - MAGETWO-82747 [TASK] Updated user.ini according to Magento DevDocs #11734
 - MAGETWO-82537 MAGETWO-81311: Check the length of the array before attempting to sli… #11637
 - MAGETWO-81970 Add missing translations in Magento_UI #11440
 - MAGETWO-81904 FIX #11022 in 2.2-develop: Filter Groups of search criteria parameter have not been included for further processing #11421
 - MAGETWO-82179 Fix Filter Customer Report Review 2.2-develop [Backport] #11522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Award: test coverage bug report Component: Customer Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
October 2017
Development

Successfully merging this pull request may close these issues.
5 participants
@osrecio @magento-team @vkublytskyi @ishakhsuvarov @okorshenko