Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation and lock_expires to customer export csv - Fix issue 10765 #11437

Merged
merged 5 commits into from
Oct 18, 2017

Conversation

convenient
Copy link
Contributor

@convenient convenient commented Oct 13, 2017

Description

Port of #10915 to the from the develop branch to the 2.2-develop branch.

Add confirmation and lock_expires to customer export csv.

Fixed Issues (if relevant)

#10765 (A SQUASHTOBERFEST issue)

Manual testing scenarios

  1. Ensure at least one customer exists in your database
  2. login to admin panel
  3. Add the "Account lock" and "Confirmed Email" columns to your customer grid
  4. Click on export button to export details in CSV format.
  5. See these fields being populated with values, previously they were null.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

isConfirmationRequired -> isConfirmRequired

Keep the variable name less than 20 chars
@convenient
Copy link
Contributor Author

So close!

I guess you're having a few errors with travis?

Configuration: /home/travis/build/magento/magento2/dev/tests/functional/phpunit.xml
................
The job exceeded the maximum time limit for jobs, and has been terminated.

@okorshenko okorshenko merged commit 69151ea into magento:2.2-develop Oct 18, 2017
okorshenko pushed a commit that referenced this pull request Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants