Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#10765 add confirmation and lock expires data to customer grid CSV export #10915

Merged
merged 4 commits into from
Nov 27, 2017
Merged

#10765 add confirmation and lock expires data to customer grid CSV export #10915

merged 4 commits into from
Nov 27, 2017

Conversation

Zefiryn
Copy link
Contributor

@Zefiryn Zefiryn commented Sep 17, 2017 •
edited by ishakhsuvarov
Loading

Description

Adding methods to set text values for data pulled from customer_grid_flat table during CSV export

Fixed Issues (if relevant)

#10765

Manual testing scenarios

  1. login to admin panel.
  2. Go to customer panel, and click on export button to export details in CSV format.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 17, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ishakhsuvarov
ishakhsuvarov reviewed Sep 17, 2017
View reviewed changes
app/code/Magento/Customer/Ui/Component/DataProvider/Document.php Outdated
*/
public function __construct(
AttributeValueFactory $attributeValueFactory,
GroupRepositoryInterface $groupRepository,
CustomerMetadataInterface $customerMetadata,
StoreManagerInterface $storeManager
StoreManagerInterface $storeManager,
ScopeConfigInterface $scopeConfig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to backwards compatibility policy we can not add new required parameters to the constructor as it may break the existing code, which could extend from this class.
To overcome this – new parameter should be introduced as nullable.
Please refer to the Backwards COmpatible Development Guide for example

ishakhsuvarov
ishakhsuvarov reviewed Sep 17, 2017
View reviewed changes
app/code/Magento/Customer/Ui/Component/DataProvider/Document.php Outdated
ScopeInterface::SCOPE_WEBSITES,
$websiteId);

$valueText = !$isConfirmationRequired ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest refactoring this part to make it more human-readable to simplify future debugging and improvements

@ishakhsuvarov ishakhsuvarov self-assigned this Sep 17, 2017
@ishakhsuvarov ishakhsuvarov added this to the September 2017 milestone Sep 17, 2017
@convenient convenient mentioned this pull request Oct 13, 2017
Merged
4 tasks
@magento-engcom-team magento-engcom-team changed the base branch from develop to 2.3-develop October 20, 2017 15:33
@okorshenko okorshenko modified the milestones: October 2017, November 2017 Nov 1, 2017
@magento-engcom-team magento-engcom-team added 2.2.x bugfix Fixed in 2.2.x The issue has been fixed in 2.2 release line labels Nov 7, 2017
@okorshenko okorshenko self-assigned this Nov 20, 2017
@okorshenko
Copy link
Contributor

Hi @Zefiryn
Unfortunatelly we can not process this PR. Remote branch has been deleted

hatimeria-artur-jewula deleted the Zefiryn:10765  branch 5 days ago

@okorshenko okorshenko closed this Nov 20, 2017
@okorshenko
Copy link
Contributor

Could you please submit the PR one more time

@Zefiryn
Copy link
Contributor Author

Zefiryn commented Nov 21, 2017

@okorshenko Changes have been merged to 2.2. I created new PR with ports to 2.1-develop and 2.3-develop

@okorshenko okorshenko reopened this Nov 22, 2017
@okorshenko okorshenko merged commit 0c1589b into magento:2.3-develop Nov 27, 2017
okorshenko pushed a commit that referenced this pull request Nov 27, 2017
@ishakhsuvarov
MAGETWO-84374: #10765 add confirmation and lock expires data to custo…
c12404c 
…mer grid CSV export #10915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishakhsuvarov ishakhsuvarov ishakhsuvarov left review comments

Assignees

@ishakhsuvarov ishakhsuvarov

@okorshenko okorshenko

Labels
bugfix Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept
Projects
None yet
Milestone
November 2017
Development

Successfully merging this pull request may close these issues.
7 participants
@Zefiryn @magento-cicd2 @okorshenko @ishakhsuvarov @magento-team @magento-engcom-team @hatimeria-artur-jewula