Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trim filter to first, middle and lastname. #11051

Closed
wants to merge 3 commits into from

Conversation

wardcapp
Copy link
Contributor

@wardcapp wardcapp commented Sep 26, 2017

Description

The additional trim form field data filter was created and added as
input filter to the firstname, lastname and middlename fields
of the customer_address and customer entities.

Fixed Issues (if relevant)

  1. Customer First and Last names not being trimmed of leading and trailing spaces on save. #10415: Customer First and Last names not being trimmed of leading and trailing spaces on save.

Manual testing scenarios

  1. Create a new customer from the Customers > All Customers > Create New Customer window
  2. Create First name: "John " Last name: " Doe ", add a fake email address.
  3. Click save
  4. Search and edit the contact "John Doe "
  5. Take note that the spaces are no longer in the users first, middle and last names. Same goes for the customer names set on the customer addresses.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

heyitsroberthe and others added 3 commits September 12, 2017 20:36
[mpi] MAGETWO-72551: Update version in composer to 2.2.1-dev for 2.2-develop branch
The additional trim form field data filter was created and added as
input filter to the firstname, lastname and middlename fields
of the customer_address and customer entities.

Tickets: magento#10415
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 29, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ wardcapp
❌ paliarush
❌ viktym

@wardcapp
Copy link
Contributor Author

wardcapp commented Jan 2, 2018

Deleted the earlier set up branch by accident, my bad. The pull request was re-created, making sure the fix can still be merged (see #12964).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants