Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customer First and Last names not being trimmed of leading and trailing spaces on save. #10415

Closed
spyrule opened this issue Aug 3, 2017 · 5 comments
Closed

Customer First and Last names not being trimmed of leading and trailing spaces on save. #10415

spyrule opened this issue Aug 3, 2017 · 5 comments
Assignees
@wardcapp
Labels
bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@spyrule
Copy link

spyrule commented Aug 3, 2017

When you create a new contact, if there is a leading or trailing space with no characters after, those are not being trimmed.

Names should be saved with no trailing/leading spaces as this breaks many search tools.

Preconditions

  1. Magento 2.1.3
  2. php 7
  3. MySQL (hosted, not sure of the version)

Steps to reproduce

  1. Create a new customer from the Customers > All Customers > Create New Customer window
  2. Create First name: "John " Last name: " Doe ", add a fake email address.
  3. Click save
  4. Search and edit the contact "John Doe "
  5. Take note that the spaces are saved in the users first and last names.

Expected result

  1. First, Middle and Last names should have and leading and trailing spaces removed on save.

Actual result

  1. Leading/Trailing spaces are left in the names of the customer.
@The-Krang The-Krang mentioned this issue Aug 3, 2017
Closed
@magento-engcom-team magento-engcom-team added G1 Passed bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Sep 18, 2017
@magento-engcom-team
Copy link
Contributor

@spyrule thank you for your bug report.
We've created internal ticket MAGETWO-75491 to track progress on the issue.

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Sep 19, 2017
@stevenvdp
Copy link
Contributor

I'll take a look at this

wardcapp added a commit to wardcapp/magento2 that referenced this issue Sep 26, 2017
@wardcapp
Add trim filter to first, middle and lastname.
8593966 
The additional trim form field data filter was created and added as
input filter to the firstname, lastname and middlename fields
of the customer_address and customer entities.

Tickets: magento#10415
@wardcapp wardcapp mentioned this issue Sep 26, 2017
Closed
4 tasks
@okorshenko
Copy link
Contributor

Hi @stevenvdp could you please accept the invitation to join Magento team on the GitHub?

@angelo983 angelo983 mentioned this issue Oct 10, 2017
Closed
wardcapp added a commit to wardcapp/magento2 that referenced this issue Jan 2, 2018
@wardcapp
Add trim filter to first, middle and lastname.
207fdb0 
The additional trim form field data filter was created and added as
input filter to the firstname, lastname and middlename fields
of the customer_address and customer entities.

Tickets: magento#10415
@wardcapp wardcapp mentioned this issue Jan 2, 2018
Merged
4 tasks
wardcapp added a commit to wardcapp/magento2 that referenced this issue Jan 5, 2018
@wardcapp
Add trim filter to first, middle and lastname.
e8dad7a 
The additional trim form field data filter was created and added as
input filter to the firstname, lastname and middlename fields
of the customer_address and customer entities.

Tickets: magento#10415
@wardcapp wardcapp mentioned this issue Jan 5, 2018
Merged
4 tasks
@magento-team
Copy link
Contributor

Hi @spyrule. Thank you for your report.
The issue has been fixed in #12964 by @wardcapp in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-team magento-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 9, 2018
@magento-team
Copy link
Contributor

Hi @spyrule. Thank you for your report.
The issue has been fixed in #13012 by @wardcapp in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-team magento-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 11, 2018
@richardreen richardreen mentioned this issue Oct 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wardcapp wardcapp

Labels
bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@magento-team @stevenvdp @wardcapp @okorshenko @vherasymenko @spyrule @magento-engcom-team