-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty requirejs-config when using https #5977
Comments
The problem lies here https://github.com/magento/magento2/blob/2.1/lib/internal/Magento/Framework/View/Asset/File/FallbackContext.php#L106 and here https://github.com/magento/magento2/blob/2.1/lib/internal/Magento/Framework/HTTP/PhpEnvironment/Request.php#L412 While running the At the moment the deployment script is only capable of generating secure OR unsecure content and not both. The thing is... the contents of pub/static/_requirejs/.../requirejs-config.js and pub/static/_requirejs/.../secure/requirejs-config.js are exactly the same if they are generated with developer mode on. So I wonder why the secure version is created in the first place. The release notes of the commit introducing this code don't mention anything about the http/https distinction in requirejs-config.js file generation. My proposition would be to use pub/static/_requirejs/.../requirejs-config.js for both secure and unsecure requests. I'll create a pull request for this. |
Thanks for the feedback. Unfortunately, I could not reproduce the issue. May please let me know if this issue relevant for latest release of Magento 2? And please provide the detailed steps we must follow to reproduce this issue. In addition, identify the web server you are running, the versions of MySQL, and any other information needed to reproduce your issue. |
According to contributor guide, tickets without response for two weeks should be closed. |
@IlnitskiyArtem & @veloraven: this is probably a duplicate of #4961, you can find a little bit of info over there about how to reproduce. |
Media modules moved from ASI
I recently switched a production store to have backend and frontend protected pages under https (using the configuration panel). When recompiling static assets then _pub/static/requirejs/adminhtml/Magento/backend/en_US/secure/requirejs-config.js is empty and the website is broken.
Switching back to http solves the issue.
Preconditions
Steps to reproduce
Expected result
Actual result
The text was updated successfully, but these errors were encountered: