Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static-deploy does not generate all static files: _requirejs only generated on demand #4961

Closed
ludwig-gramberg opened this issue Jun 10, 2016 · 5 comments
Labels
Area: Frontend bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Progress: needs update

Comments

@ludwig-gramberg
Copy link

ludwig-gramberg commented Jun 10, 2016

this should be fixed, if I deploy my static code to production the command should trigger the creation of the files in pub/static/_requirejs and pub/static/_requirejs/secure as well

@wert2all wert2all self-assigned this Jun 23, 2016
@wert2all wert2all removed their assignment Jun 23, 2016
@hostep
Copy link
Contributor

hostep commented Sep 14, 2016

Nice find @ludwig-gramberg!

I just tested this using Magento CE 2.1.1 with the following configurations:

  • secure url's enabled (https)
  • js minifying enabled
  • js bundling enabled

These files are created at deploy time:

  • pub/static/_requirejs/frontend/{Vendor}/{theme}/{locale}/requirejs-config.min.js
  • pub/static/frontend/{Vendor}/{theme}/{locale}/Magento_Cookie/js/require-cookie.min.js
  • pub/static/frontend/{Vendor}/{theme}/{locale}/requirejs/require.min.js
  • pub/static/frontend/{Vendor}/{theme}/{locale}/requirejs-min-resolver.min.js

These files are created on the first request:

  • pub/static/_requirejs/frontend/{Vendor}/{theme}/{locale}/secure/requirejs-config.min.js
  • pub/static/frontend/{Vendor}/{theme}/{locale}/secure/requirejs-min-resolver.min.js

So only the secure assets aren't created at deployment time.

I stumbled upon this workaround (which I haven't tested yet) which might get us around this "problem" for now: davidalger/capistrano-magento2#21

@ludwig-gramberg
Copy link
Author

still an issue in 2.1.2

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 14, 2017

@ludwig-gramberg, thank you for your report.
Please use the issue reporting guidelines to report an issue. Include the preconditions, the steps required to reproduce, the actual result, and the expected result.
Please, add the following information:

  • Preconditions: Magento version
  • Steps to reproduce
  • Expected result
  • Actual result

@hostep
Copy link
Contributor

hostep commented Sep 14, 2017

I believe this got fixed in Magento 2.1.8, I tested it a couple of weeks ago, so this issue can probably be closed?

From the release notes:

Static content deployment now generates secure content, whether content included secure or non-secure URLs.

@magento-engcom-team
Copy link
Contributor

Hi @hostep
Thank you for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Progress: needs update
Projects
None yet
Development

No branches or pull requests

7 participants