Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS on #21

Closed
clicktrend opened this issue Sep 1, 2016 · 4 comments
Closed

HTTPS on #21

clicktrend opened this issue Sep 1, 2016 · 4 comments

Comments

@clicktrend
Copy link

clicktrend commented Sep 1, 2016

Hi,

due to my server configuration I need to run this static-content:deploy command:

HTTPS=on php bin/magento setup:static-content:deploy en_US

This creates static files in "secure" directory. To deploy this with capistrano I created this task

desc "Deploy static files"
task :static_deploy do
    on roles(:app) do
        within release_path do
            execute "cd '#{release_path}' && HTTPS=on php bin/magento setup:static-content:deploy en_US"
        end
    end
end

Is it possible to pass "HTTPS=on" in your script?

@davidalger
Copy link
Owner

@clicktrend Based on my checking, the only additional files created by running the tool with HTTPS=on are secure versions of the requirejs-config.js files. To this end, I've implemented it so that in Magento 2.1, the new options in the tool will be taken advantage of to speed things up, while still allowing the command to generate both non-secure and secure versions of the files.

This work was done in commit 8881466 and 1ccc7c4.

If this does not accomplish what you need, please let me know!

@davidalger
Copy link
Owner

Note: This will be included in the next tagged release, which I plan on tagging shortly. :)

@hostep
Copy link

hostep commented Sep 14, 2016

Let's cross reference this issue with the corresponding issue in Magento2: magento/magento2#4961

@davidalger
Copy link
Owner

Good call, @hostep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants