Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFTF: Acceptance tests break the naming convention #27503

Closed
3 of 47 tasks
lbajsarowicz opened this issue Mar 30, 2020 · 4 comments
Closed
3 of 47 tasks

MFTF: Acceptance tests break the naming convention #27503

lbajsarowicz opened this issue Mar 30, 2020 · 4 comments
Assignees
@konarshankar07
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch good first issue Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reported on 2.3.x Indicates original Magento version for the Issue report.

Comments

@lbajsarowicz
Copy link
Contributor

lbajsarowicz commented Mar 30, 2020 •
edited
Loading

Preconditions (*)

All the Magento Functional Testing Framework should follow Technical Guidelines:
https://devdocs.magento.com/guides/v2.3/coding-standards/technical-guidelines.html#113-functional-testing

Steps to reproduce (*)

  1. Generate tests with vendor/bin/mftf generate:test -f

Expected result (*)

  1. No naming violations detected

Actual result (*)

  1. NOTICE: 165 Section name violations detected. See mftf.log for details.
  2. NOTICE: 614 section element name violations detected. See mftf.log for details.
  3. NOTICE: 301 data entity name violations detected. See mftf.log for details.
  4. NOTICE: 15 data entity key violations detected. See mftf.log for details.
  5. NOTICE: 17 action group name violations detected. See mftf.log for details.
  6. NOTICE: 37 Page name violations detected. See mftf.log for details.

Contribution

TODO

  1. Make sure that all stepKeys both for Tests and ActionGroups are camelCase (lower first letter)
  2. Make sure that all Action Groups in module have ActionGroup suffix
  3. Make sure that all Action Groups names are consistent with the filename
  4. Make sure that all Action Groups names are PascalCase (upper first letter)
  5. Make sure that all Test names in module have Test suffix
  6. Make sure that all the test names are PascalCase
  7. Make sure that all the test names are consistent with the filename.
  8. Make sure that all Page names are Pascal Case
  9. Make sure that there is only one <page> node in each XML file

Backward compatibility

If you rename ActionGroup please try to keep backward compatibility:

  1. Rename the ActionGroup to follow the Magento requirements
  2. Create ActionGroup/_Deprecated_/previusNameActionGroup.xml file with contents:
<actionGroup name="previousName" extends="CurrentNameActionGroup" deprecated="Use CurrentNameActionGroup"/>

this way even if someone calls old Action Group name, he is going to get the notice about deprecation.

Modules

Due to some compatibility issues and to make Code Review easier - please do your changes per module. You can find list of checkboxes underneath with list of modules that should be covered. When you start working on specific module, please check the chekbox and add the comment which module you start work. When you finish - edit your commend adding the link to PR.

Once you finished, make sure that vendor/bin/mftf generate:test -f does not return any errors.

Open Source

  • app/code/Magento/Catalog (6484 issues)
  • app/code/Magento/Cms (2187 issues)
  • app/code/Magento/Sales (1006 issues)
  • app/code/Magento/Config (660 issues)
  • app/code/Magento/Newsletter (631 issues)
  • app/code/Magento/Shipping (604 issues)
  • app/code/Magento/Store (554 issues)
  • app/code/Magento/Checkout (552 issues)
  • app/code/Magento/Customer (390 issues)
  • app/code/Magento/Wishlist (361 issues)
  • app/code/Magento/Tax (330 issues)
  • app/code/Magento/ConfigurableProduct (316 issues)
  • app/code/Magento/CatalogSearch (270 issues)
  • app/code/Magento/User (240 issues)
  • app/code/Magento/Paypal (210 issues)
  • app/code/Magento/Ui (195 issues)
  • app/code/Magento/SalesRule (173 issues)
  • app/code/Magento/Multishipping (138 issues)
  • app/code/Magento/Reports (137 issues)
  • app/code/Magento/Downloadable (105 issues)
  • app/code/Magento/Braintree (105 issues)
  • app/code/Magento/CatalogRule (98 issues)
  • app/code/Magento/Widget (90 issues)
  • app/code/Magento/LayeredNavigation (90 issues)
  • app/code/Magento/CatalogInventory (83 issues)
  • app/code/Magento/Swatches (75 issues)
  • app/code/Magento/CatalogWidget (75 issues)
  • app/code/Magento/UrlRewrite (60 issues)
  • app/code/Magento/Backend (57 issues)
  • app/code/Magento/Translation (45 issues)
  • app/code/Magento/Review (45 issues)
  • app/code/Magento/CheckoutAgreements (45 issues)
  • app/code/Magento/Analytics (45 issues)
  • app/code/Magento/Bundle (37 issues)
  • app/code/Magento/Theme (31 issues)
  • app/code/Magento/Variable (30 issues)
  • app/code/Magento/Persistent (30 issues)
  • app/code/Magento/GroupedProduct (30 issues)
  • app/code/Magento/CurrencySymbol (23 issues)
  • app/code/Magento/Weee (15 issues)
  • app/code/Magento/ProductVideo (15 issues)
  • app/code/Magento/PageCache (15 issues)
  • app/code/Magento/Integration (15 issues)
  • app/code/Magento/GiftMessage (15 issues)
  • app/code/Magento/Captcha (15 issues)
  • app/code/Magento/Backup (9 issues)
  • app/code/Magento/Indexer (2 issues)
@m2-assistant
Copy link

m2-assistant bot commented Mar 30, 2020

Hi @lbajsarowicz. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@lbajsarowicz do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 30, 2020
@konarshankar07
Copy link
Contributor

konarshankar07 commented Mar 31, 2020 •
edited
Loading

I'm working on Magento/Indexer, Magento/Backup, Magento/Captcha modules

@konarshankar07 konarshankar07 mentioned this issue Mar 31, 2020
Merged
4 tasks
@ghost ghost assigned konarshankar07 Mar 31, 2020
@konarshankar07 konarshankar07 mentioned this issue Apr 2, 2020
Merged
lbajsarowicz added a commit to lbajsarowicz/magento2-contributions that referenced this issue Apr 5, 2020
@lbajsarowicz
magento#27503 Final fix for Page name violation
9fab7a1
@lbajsarowicz lbajsarowicz mentioned this issue Apr 5, 2020
Closed
4 tasks
@ghost ghost assigned lbajsarowicz Apr 5, 2020
@ghost ghost unassigned lbajsarowicz Apr 18, 2020
magento-engcom-team added a commit that referenced this issue Apr 29, 2020
@magento-engcom-team
ENGCOM-7421: #27503 : MFTF: Acceptance tests break the naming convent…
b11dd5a 
…ion (Indexer + Backup) #27515

 - Merge Pull Request #27515 from konarshankar07/magento2:magento-indexer-mftf-fix
 - Merged commits:
   1. 862aff3
   2. f0d4a6d
   3. 3286bf9
   4. 5cb6457
   5. 972812d
   6. 50d7d2f
   7. 5eafb00
   8. 029446d
   9. 38cef7b
magento-engcom-team pushed a commit that referenced this issue Apr 29, 2020
@slavvka
ENGCOM-7421: #27503 : MFTF: Acceptance tests break the naming convent…
ce0f437 
…ion (Indexer + Backup) #27515
magento-engcom-team added a commit that referenced this issue Apr 29, 2020
@magento-engcom-team
🔃 [Magento Community Engineering] Community Contributions - 2.4-devel…
bb7e08f 
…op daily delivery

Accepted Community Pull Requests:
 - #27964: Deprecate AbstractAction and it's public methods (by @lbajsarowicz)
 - #27976: Can not create a subfolder with the same name as the main folder (by @engcom-Charlie)
 - #27515: #27503 : MFTF: Acceptance tests break the naming convention (Indexer + Backup) (by @konarshankar07)
 - #27994: Refactoring of the plugin responsible for the image/directory delete functionality + adjust tests (by @coderimus)
 - #26886: comments & validation added in cookie configuration (by @ajithkumar-maragathavel)
 - #27955: compliance to StorefrontMinicartSection (by @engcom-Echo)
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Apr 30, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz. Thank you for your report.
The issue has been fixed in #27515 by @konarshankar07 in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz. Thank you for your report.
The issue has been fixed in #27515 by @konarshankar07 in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

@magento-engcom-team magento-engcom-team added the Reported on 2.3.x Indicates original Magento version for the Issue report. label Nov 13, 2020
@sdzhepa sdzhepa mentioned this issue May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konarshankar07 konarshankar07

Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch good first issue Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reported on 2.3.x Indicates original Magento version for the Issue report.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lbajsarowicz @magento-engcom-team @konarshankar07