comments & validation added in cookie configuration

[ajithkumar-maragathavel]

Description (*)

Go to Stores -> Settings -> Configuration -> General -> Web and expand Default Cookie Settings section.

1. Added comments to each field for a better understanding of the admin user.
2. Added number validation for cookie lifetime field to make sure it only accepts numbers.

Manual testing scenarios (*)

1. Given string characters in the cookie lifetime field and verify number validation is working
2. Verify the comments are displayed under each field of the section.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ajithkumar-maragathavel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[rogyar]

Hi @ajithkumar-maragathavel. Thank you for providing this change. I would kindly ask you to cover the validation process using an MFTF test.

Please, follow the best practices for functional tests described here

[ajithkumar-maragathavel]

@rogyar I will cover the changes with the MFTF test and will commit the changes and let you know.
Thanks for the review.

[ajithkumar-maragathavel]

@rogyar I have covered the validation using the MFTF test. Please review it and share your suggestions.

[rogyar]

Hi @ajithkumar-maragathavel. Thank you for covering the solution with MFTF test, great job!

There's one more improvement that we can bring here. In the test, you've covered only the negative scenario (putting invalid value to the field). We may also introduce a positive scenario. So the steps will be the following:

• Go to settings, fill the field with an incorrect value
• Assert that the validation error is present
• Fill the field with the correct value
• Assert that there's no validation error.

Thank you!

[ajithkumar-maragathavel]

Hi @ajithkumar-maragathavel. Thank you for covering the solution with MFTF test, great job!

There's one more improvement that we can bring here. In the test, you've covered only the negative scenario (putting invalid value to the field). We may also introduce a positive scenario. So the steps will be the following:

* Go to settings, fill the field with an incorrect value

* Assert that the validation error is present

* Fill the field with the correct value

* Assert that there's no validation error.

Thank you!

@rogyar Thanks for the review. I will also cover the positive scenario.
Just have one doubt. Please clarify me.

The assertion should be written as a separate action group. Right?

[ajithkumar-maragathavel]

@rogyar I have also covered the positive case scenario for the cookie lifetime save operation in Magento admin. Please review it.

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-7488 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Before:

After:

[engcom-Echo]

@magento run Functional Tests B2B, Functional Tests EE

[engcom-Echo]

Failed functional tests not related to the changes in this PR

[m2-assistant]

Hi @ajithkumar-maragathavel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.