Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sort dropdown styles #715

Closed
wants to merge 1 commit into from
Closed

Fixed sort dropdown styles #715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions AdobeStockImageAdminUi/view/adminhtml/web/css/source/_module.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@

select {
border: none;
background-image: url(../images/arrows-bg.svg);
padding-right: 2.2rem;
background-image: url(../images/arrows-bg.svg) !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the desired appearance be achieved without !important notation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think so, since:

Added !important to dropdown arrow background as the default background has the !important already (reference) which is overriding our custom dropdown style

Copy link
Member

@sivaschenko sivaschenko Nov 17, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, that is a defect in my opinion. Would you be able to revert the PR that introduce that commit for magento2 (magento/magento2#25022)? (one that PR will be merged magento/magento2#24840 should be reopened)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I will do that and then fix this after. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

padding-right: 2.4rem;

&:active {
background-image+: url('../images/arrows-bg.svg');
Expand Down
4 changes: 2 additions & 2 deletions AdobeStockImageAdminUi/view/adminhtml/web/template/grid/toolbar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@
'col-xs-10': hasChild('listing_massaction'),
'col-xs-12': !hasChild('listing_massaction')">
<div class="row">
<div class="col-xs-4">
<div class="col-xs-5">
<div class="masonry-results-number" ko-scope="requestChild('listing_paging')">
<render args="totalTmpl"/>
</div>
<each args="getRegion('sorting')" render=""/>
</div>
<div class="col-xs-8" ko-scope="requestChild('listing_paging')">
<div class="col-xs-7" ko-scope="requestChild('listing_paging')">
<div render=""/>
</div>
</div>
Expand Down