Fixed sort dropdown styles #715
Conversation
There was a problem hiding this comment.
Hi @drpayyne thanks for the pull request! Please take a look at my review comment
| @@ -97,8 +97,8 @@ | |||
|
|
|||
| select { | |||
| border: none; | |||
| background-image: url(../images/arrows-bg.svg); | |||
| padding-right: 2.2rem; | |||
| background-image: url(../images/arrows-bg.svg) !important; | |||
There was a problem hiding this comment.
Can the desired appearance be achieved without !important notation?
There was a problem hiding this comment.
Don't think so, since:
Added !important to dropdown arrow background as the default background has the !important already (reference) which is overriding our custom dropdown style
There was a problem hiding this comment.
Hm, that is a defect in my opinion. Would you be able to revert the PR that introduce that commit for magento2 (magento/magento2#25022)? (one that PR will be merged magento/magento2#24840 should be reopened)
There was a problem hiding this comment.
Alright, I will do that and then fix this after. Thanks!
|
Depends on magento/magento2#25629 |
|
Hi @sivaschenko, I just tested the Magento instance with this PR revert: magento/magento2#25629 and turns out we don't need any extra code. There was already some code written by you here: https://github.com/magento/adobe-stock-integration/blob/develop/AdobeStockImageAdminUi/view/adminhtml/web/css/source/_module.less#L99 which does the necessary styling. I think we can close this PR once you can test it too and verify, and close the issue once the PR revert in magento2 repository is merged. Thanks! |
|
@drpayyne great, thanks! Then let's just wait for the revert to merge! |
|
Hi @drpayyne, thank you for your contribution! |
Description
!importantto dropdown arrow background as the default background has the!importantalready (reference) which is overriding our custom dropdown styleFixed Issues
Manual testing scenarios