Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisions #23

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Revisions #23

merged 2 commits into from
Aug 29, 2024

Conversation

maddieford
Copy link
Owner

Description

Issue #

PR information

  • Ensure development PR is based on the develop branch.
  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@maddieford maddieford merged commit 260daeb into encoded_signature Aug 29, 2024
20 checks passed
@maddieford maddieford deleted the revisions branch August 29, 2024 17:39
maddieford added a commit that referenced this pull request Aug 30, 2024
@maddieford
Parse encodedSignature property from EGS (Azure#3200)
86febb7 
* Consume encoded_signature property from EGS (#22)

* Pylint/test changes

* Update unit tests

* formatting

* add comment

* Generalize test data

* Add encoded_signature None case comment for VmSettings

* Revisions (#23)

* Respond to comments

* check remaining extensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maddieford