Parse encodedSignature property from EGS #3200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pylint/test changes * Update unit tests * formatting * add comment * Generalize test data
maddieford
requested review from
narrieta,
ZhidongPeng and
nagworld9
as code owners
maddieford
changed the title
narrieta
reviewed
Aug 29, 2024
azurelinuxagent/common/protocol/extensions_goal_state_from_extensions_config.py
Outdated
Show resolved
Hide resolved
narrieta
reviewed
Aug 29, 2024
| data_file = wire_protocol_data.DATA_FILE.copy() | ||
| # This extensions goal state has 1 extension without encodedSignature property (ExampleHandlerLinux) and 1 | ||
| # extension with encodedSignature property (ExampleExtension) | ||
| data_file["ext_conf"] = "wire/ext_conf-plugin_encoded_signature.xml" |
There was a problem hiding this comment.
should we just add the signature to wire/ext_conf.xml and hostgaplugin/vm_settings.json so that most test will get the values? the signature will be a standard property now
* Respond to comments * check remaining extensions
narrieta
approved these changes
Aug 29, 2024
nagworld9
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some extensions are now being published with a signature. If an extension is signed, its signature will be included in the extensions goal state using the 'encodedSignature' property. If an extension is not signed, extensions goal state will not include an 'encodedSignature' property for that extension. This is true for extensions config and vmsettings.
This PR adds the encoded_signature instance variable to the Extension object model. Its value should be None if the 'encodedSignature' property does not exist for the extension in the extensions goal state.
Issue #
PR information
Quality of Code and Contribution Guidelines