Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc: add missing build dependencies, fix notes: PDF docs arent't built, fix typo, drop maintainership #5049

Merged
merged 3 commits into from
Aug 19, 2019

Conversation

neverpanic
Copy link
Member

Description

Cc: @essandess.

This is a combination of three commits:

  • ghc: Add missing build dependencies
    The bootstrap variant now requires autoconf and automake to be installed
    for the build to succeed. This was caught by trace mode.
  • ghc: Fix notes: PDF docs arent't built, fix typo
    The PDF documentation wasn't built in my local build with trace mode, so
    remove the line from the notes section since it points to a non-existant
    file.
    Additionally, fix a typo in the notes message.
  • ghc: Drop maintainership
    I clearly don't have the time to maintain this.
Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.12.6 16G2128
Xcode 9.2 9C40b

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

The bootstrap variant now requires autoconf and automake to be installed
for the build to succeed. This was caught by trace mode.
The PDF documentation wasn't built in my local build with trace mode, so
remove the line from the notes section since it points to a non-existant
file.

Additionally, fix a typo in the notes message.
I clearly don't have the time to maintain this.
@macportsbot
Copy link

Notifying maintainers:
@essandess for port ghc.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer maintainer: open Affects an openmaintainer port type: bugfix labels Aug 19, 2019
@macportsbot
Copy link

Travis Build #7777 Errored.

Lint results
--->  Verifying Portfile for ghc
--->  0 errors and 0 warnings found.

Port ghc's dependencies fail on xcode8.3. Log

The build timed out.

@essandess
Copy link
Contributor

@neverpanic Thanks. This needs a line:

revision 1

Hoping this fixes the current autoreconf Issue in #4715

@neverpanic
Copy link
Member Author

I would argue it doesn't need the revision 1 line. Either the port did build correctly for people (because they didn't build in trace mode and had autoconf and automake installed), or it didn't build at all, so there is no need to force a rebuild.

The maintainer change and notes change don't need a rebuild either, because those are always taken from the Portfile in-tree, not the state at install time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port maintainer type: bugfix
Development

Successfully merging this pull request may close these issues.

3 participants