WIP ShellCheck: update to 0.6.0 #4577

sirn · 2019-06-11T05:21:07Z

Description

This PR update ShellCheck to 0.6.0 and upgrade/introduce a new port of all dependencies required to get it running. ShellCheck has since switched from hs-json to hs-aeson, and even though ShellCheck dependencies says any version of aeson is fine, it actually requires a newer version of aeson (thus existing hs-aeson does not work).

So instead of updating hs-aeson, which may break other packages in process, I decided to create hs-aeson-devel and add new port for its dependencies, using -devel suffix in its name (if the package already exists). Some -devel package can be link against the existing hs-hashable in MacPorts, but hs-aeson-devel require hashable >=1.2.7.0, so I have to link its dependencies with hs-hashable-devel because otherwise hs-aeson will fail to build (due to deriving error with Hashable Text).

I tried to keep the dependencies tree clean by following few rules:

Any dependencies of hs-aeson-devel are linked against hs-hashable-devel
Any -devel packages are linked against -devel packages instead of haskell-platform
Any non--devel packages are linked against packages in haskell-platforms if possible

Please consider this PR as a WIP, as I believe it require a lot more work to be done before it can be merged, but I need feedback from existing maintainers, so I'm sorry for opening a WIP PR.

Thanks!

Type(s)

bugfix
enhancement
security fix

Tested on

macOS 10.15 19A471t
Xcode 11.0 11M336w

Verification

Have you

followed our Commit Message Guidelines?
squashed and minimized your commits?
checked that there aren't other open pull requests for the same change?
checked your Portfile with port lint?
tried a full install with sudo port -vst install?
tested basic functionality of all binary files?

I used sudo port -vs install to install because I cannot enable tracing on GHC possibly because I'm running a beta software (sorry about this); the process simply hangs and require kill -9 to exit.

macportsbot · 2019-06-11T05:21:10Z

Notifying maintainers:
@neverpanic for port hs-dlist, hs-tagged, shellcheck.

macportsbot · 2019-06-11T06:36:39Z

Travis Build #6832 Canceled.

Lint results

--->  Verifying Portfile for hs-aeson-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-attoparsec-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-base-compat
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-contravariant
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-dlist
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-fail
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-generic-deriving
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-hashable-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-integer-logarithms
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-mtl-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-nats-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-primitive-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-scientific-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-semigroups-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-statevar
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-tagged
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-text-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-th-abstraction
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-time-locale-compat
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-transformers-compat
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-transformers-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-unordered-containers-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-uuid-types
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-vector-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-void-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for shellcheck
--->  0 errors and 0 warnings found.

Port hs-aeson-devel's dependencies fail on xcode10.2. Log
Port hs-attoparsec-devel's dependencies fail on xcode10.2. Log
Port hs-base-compat success on xcode10.2. Log
Port hs-contravariant's dependencies fail on xcode10.2. Log
Port hs-dlist success on xcode10.2. Log
Port hs-fail success on xcode10.2. Log
Port hs-generic-deriving success on xcode10.2. Log
Port hs-hashable-devel success on xcode10.2. Log
Port hs-integer-logarithms success on xcode10.2. Log
Port hs-mtl-devel success on xcode10.2. Log
Port hs-nats-devel success on xcode10.2. Log
Port hs-primitive-devel success on xcode10.2. Log
Port hs-scientific-devel success on xcode10.2. Log
Port hs-semigroups-devel's dependencies fail on xcode10.2. Log
Port hs-statevar success on xcode10.2. Log
Port hs-tagged's dependencies fail on xcode10.2. Log
Port hs-text-devel success on xcode10.2. Log
Port hs-th-abstraction success on xcode10.2. Log
Port hs-aeson-devel's dependencies fail on xcode9.4. Log
Port hs-attoparsec-devel's dependencies fail on xcode9.4. Log
Port hs-base-compat success on xcode9.4. Log
Port hs-contravariant's dependencies fail on xcode9.4. Log
Port hs-dlist success on xcode9.4. Log
Port hs-fail success on xcode9.4. Log
Port hs-generic-deriving success on xcode9.4. Log
Port hs-hashable-devel success on xcode9.4. Log
Port hs-integer-logarithms success on xcode9.4. Log
Port hs-mtl-devel success on xcode9.4. Log
Port hs-nats-devel success on xcode9.4. Log
Port hs-primitive-devel success on xcode9.4. Log
Port hs-scientific-devel success on xcode9.4. Log

The build timed out.

macportsbot · 2019-06-11T14:56:37Z

Travis Build #6839 Errored.

Lint results

--->  Verifying Portfile for hs-aeson-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-attoparsec-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-base-compat
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-contravariant
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-dlist
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-fail
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-generic-deriving
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-hashable-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-integer-logarithms
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-mtl-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-nats-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-primitive-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-scientific-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-semigroups-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-statevar
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-tagged
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-text-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-th-abstraction
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-time-locale-compat
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-transformers-compat
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-transformers-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-unordered-containers-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-uuid-types
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-vector-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for hs-void-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for shellcheck
--->  0 errors and 0 warnings found.

The build timed out.

pmetzger · 2019-06-21T15:16:16Z

@cjones051073 Are you shepherding this?

sirn · 2019-06-24T10:34:07Z

Heads-up, my Mac is currently dead so I can’t work on this for a week, but please do leave comment! Thanks!

neverpanic · 2019-08-19T22:39:28Z

Sorry for not seeing this any earlier – there is currently some work going on to get Haskell modernized based on stack, see #4794, #5049, #4633 and as an example port update, #4698.

We may eventually go down the stack-based route, since it's just much easier to package the binaries we want without worrying about all the different library dependencies.

Cc: @essandess.

sirn · 2019-08-20T17:31:06Z

Makes sense, I actually prefer stack-based installations than manually managing dependencies (of which I have no idea what to do with the -devel packages once MacPorts updated GHC :-) I may find some time to port ShellCheck to stack-based build once the relevant PRs are merged.

essandess · 2019-08-20T17:57:00Z

I may find some time to port ShellCheck to stack-based build once the relevant PRs are merged.

@sirn It’s pretty fast and simple. Here are a couple examples:

essandess · 2019-08-21T11:59:40Z

@sirn BTW, it would be helpful if you looked at those Portfile examples with a critical eye. Specifically, I haven’t fully checked if those .env settings are actually used or necessary (MacPorts tcl is opaque in this way). And I haven’t tried to get a working build with MacPorts gcc. Though that should work, running it out-of-the-box breaks stack builds, so I explicitly set the macOS native gcc.

Please post any corrections you feel are necessary, or a way to use MacPorts compilers if you get a chance to figure that one out.

sirn · 2019-08-21T15:00:07Z

@essandess I'll take a look and will try to port this to stack-based Portfile during the weekend. Thanks!

essandess · 2019-08-21T16:05:39Z

@sirn Also, take a critical look at the binary that stack produces. stack doesn’t really do DESTDIR or PREFIX. Often it works anyway. If not, some hackiness will be required.

neverpanic · 2019-08-27T15:28:10Z

Right, I should have checked before, but shellcheck was just updated to 0.7.0 in #5142.

sirn added 12 commits June 11, 2019 11:50

hs-dlist: update to 0.8.0.6

06ddd22

hs-fail: 4.9.0.0 (new port)

2cda06b

hs-base-compat: 0.10.5 (new port)

5612fc4

hs-statevar: 1.2 (new port)

52b8df5

hs-th-abstraction: 0.3.1.0 (new port)

8879cb4

hs-generic-deriving: 1.12.4 (new port)

b19d151

hs-transformers-devel: 0.5.6.2 (new port)

fd07baa

hs-text-devel: 1.2.3.1 (new port)

6b61bd7

hs-hashable-devel: 1.2.7.0 (new port)

2782898

hs-mtl-devel: 2.2.2 new port

f3a08db

hs-time-locale-compat: 0.1.1.5 (new port)

03ca747

hs-nats-devel: 1.1.2 (new port)

bbfd8b6

macportsbot assigned neverpanic Jun 11, 2019

macportsbot added maintainer: open Affects an openmaintainer port type: enhancement type: submission type: update labels Jun 11, 2019

sirn added 11 commits June 11, 2019 19:37

hs-transformers-compat: 0.6.5 (new port)

bd677fe

hs-unordered-containers-devel: 0.2.10.0 (new port)

90ee68b

hs-tagged: update to 0.8.6

d44ed43

hs-semigroups-devel: 0.18.5 (new port)

b240b71

hs-integer-logarithms: 1.0.3 (new port)

dfbffb3

hs-primitive-devel: 0.6.4.0 (new port)

60e732b

hs-uuid-types: 1.0.3 (new port)

ac56389

hs-vector-devel: 0.12.0.3 (new port)

26079fa

hs-void-devel: 0.7.3 (new port)

17fe42e

hs-scientific-devel: 0.3.6.2 (new port)

1e60312

hs-contravariant: 1.5.2 (new port)

afbcf8d

sirn added 3 commits June 11, 2019 19:37

hs-attoparsec-devel: 0.13.2.2 (new port)

d617e0e

hs-aeson-devel: 1.4.3.0 (new port)

e3619ff

shellcheck: update to 0.6.0

532b788

sirn force-pushed the shellcheck-upgrade branch from 3586469 to 532b788 Compare June 11, 2019 12:38

cjones051073 changed the title ~~ShellCheck: update to 0.6.0 (WIP)~~ WIP ShellCheck: update to 0.6.0 Jun 12, 2019

cjones051073 added the wip Work in progress label Jun 12, 2019

neverpanic closed this Aug 27, 2019

sirn deleted the shellcheck-upgrade branch December 2, 2020 16:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP ShellCheck: update to 0.6.0 #4577

WIP ShellCheck: update to 0.6.0 #4577

sirn commented Jun 11, 2019 •

edited

Loading

macportsbot commented Jun 11, 2019

macportsbot commented Jun 11, 2019

macportsbot commented Jun 11, 2019

pmetzger commented Jun 21, 2019

sirn commented Jun 24, 2019

neverpanic commented Aug 19, 2019

sirn commented Aug 20, 2019

essandess commented Aug 20, 2019

essandess commented Aug 21, 2019

sirn commented Aug 21, 2019

essandess commented Aug 21, 2019

neverpanic commented Aug 27, 2019

WIP ShellCheck: update to 0.6.0 #4577

WIP ShellCheck: update to 0.6.0 #4577

Conversation

sirn commented Jun 11, 2019 • edited Loading

Description

Type(s)

Tested on

Verification

macportsbot commented Jun 11, 2019

macportsbot commented Jun 11, 2019

macportsbot commented Jun 11, 2019

pmetzger commented Jun 21, 2019

sirn commented Jun 24, 2019

neverpanic commented Aug 19, 2019

sirn commented Aug 20, 2019

essandess commented Aug 20, 2019

essandess commented Aug 21, 2019

sirn commented Aug 21, 2019

essandess commented Aug 21, 2019

neverpanic commented Aug 27, 2019

sirn commented Jun 11, 2019 •

edited

Loading