Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vpype: new port (version 1.9.0) #14251

Merged
merged 6 commits into from
Mar 22, 2022
Merged

vpype: new port (version 1.9.0) #14251

merged 6 commits into from
Mar 22, 2022

Conversation

abey79
Copy link
Contributor

@abey79 abey79 commented Mar 14, 2022

Description

New port for vpype, the "Swiss-Army-knife command-line tool for plotter vector graphics", including those dependencies which don't yet exist on MacPorts.

Note: this is my first port submission ever.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 12.2.1 21D62 arm64
Xcode 13.2.1 13C100

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?


homepage https://github.com/abey79/vpype

python.default_version 39
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MacPort's current default Python version is 3.10 - can we do the same for vpype?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Officially, vpype 1.9 doesn't support 3.10 yet, but I'm working on it for vpype 1.10 (abey79/vpype#417). The issues are mostly due to dependencies, so by further patching setup.py I might be able to make it work if this is important.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this would require to update both py-multiprocess and py-pyside2 for compatibility with 3.10. I guess this is beyond the scope of this PR.

@herbygillot
Copy link
Member

Thanks for this submission @abey79; just a few comments.

@abey79
Copy link
Contributor Author

abey79 commented Mar 14, 2022

@herbygillot Thank you very much for the feedback. I fixed the easy stuff, but I'm guess we have to stick to 3.9 for the time being.

@abey79
Copy link
Contributor Author

abey79 commented Mar 15, 2022

I'm unsure what's going on with the macOS-11 run:

Error: The following dependencies were not installed because all of them have unmet dependencies (likely due to a dependency cycle): libheif gdk-pixbuf2 gobject-introspection py310-mako py310-beaker py310-setuptools
Build of dependency 'gd2' with variants '+x11' failed, aborting.
Processing dependencies for 'vpype' failed, aborting.
/Users/runner/work/macports-ports/macports-ports/mpbb/mpbb: error: `install-dependencies' failed to run successfully
Building 'vpype' ... [ERROR] (failed to install dependency 'gd2') maintainers: ryandesign@macports.org.

The 10.15 run was cancelled this time, but it went through before I force-pushed the cosmetic changes:
https://github.com/macports/macports-ports/runs/5542137969?check_suite_focus=true


license MIT
maintainers @abey79 openmaintainer
supported_archs arm64 x86_64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it explicitly only support these two platforms or can it build on other, by MacPorts supported, ones as well. In the latter case please just remove this line and let MacPorts set its defaults

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I mentioned these archs is that glContext (and thus ModernGL) need OpenGL 3.3, which is supported by macOS 10.9 and later, which in turn restricts to the listed archs. Apart from the OGL 3.3 requirement, there is to my knowledge nothing that would preclude building on other arch, but I'm unable to test this.

I'm unsure what is the correct practice in such instance. I'm happy to remove that line if this is the right thing to do.

graphics/vpype/Portfile Outdated Show resolved Hide resolved
graphics/vpype/Portfile Outdated Show resolved Hide resolved
graphics/vpype/Portfile Outdated Show resolved Hide resolved
@reneeotten
Copy link
Contributor

thanks @abey79! A few more comments after a quick read through, some of them might/will apply to all ports in this PR.

@abey79
Copy link
Contributor Author

abey79 commented Mar 18, 2022

Thanks for your review @reneeotten! I've made fixes for all your points but one, and rebased/force pushed. Please let me know what's the best course of action for the remaining issue.

@reneeotten
Copy link
Contributor

thanks @abey79 and apologies for the delay

@reneeotten reneeotten merged commit a890ccf into macports:master Mar 22, 2022
@abey79 abey79 deleted the vpype branch May 4, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants