-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vpype: new port (version 1.9.0) #14251
Conversation
|
||
homepage https://github.com/abey79/vpype | ||
|
||
python.default_version 39 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MacPort's current default Python version is 3.10 - can we do the same for vpype
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Officially, vpype 1.9 doesn't support 3.10 yet, but I'm working on it for vpype 1.10 (abey79/vpype#417). The issues are mostly due to dependencies, so by further patching setup.py I might be able to make it work if this is important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this would require to update both py-multiprocess and py-pyside2 for compatibility with 3.10. I guess this is beyond the scope of this PR.
Thanks for this submission @abey79; just a few comments. |
@herbygillot Thank you very much for the feedback. I fixed the easy stuff, but I'm guess we have to stick to 3.9 for the time being. |
I'm unsure what's going on with the macOS-11 run:
The 10.15 run was cancelled this time, but it went through before I force-pushed the cosmetic changes: |
|
||
license MIT | ||
maintainers @abey79 openmaintainer | ||
supported_archs arm64 x86_64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it explicitly only support these two platforms or can it build on other, by MacPorts supported, ones as well. In the latter case please just remove this line and let MacPorts set its defaults
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I mentioned these archs is that glContext (and thus ModernGL) need OpenGL 3.3, which is supported by macOS 10.9 and later, which in turn restricts to the listed archs. Apart from the OGL 3.3 requirement, there is to my knowledge nothing that would preclude building on other arch, but I'm unable to test this.
I'm unsure what is the correct practice in such instance. I'm happy to remove that line if this is the right thing to do.
thanks @abey79! A few more comments after a quick read through, some of them might/will apply to all ports in this PR. |
Thanks for your review @reneeotten! I've made fixes for all your points but one, and rebased/force pushed. Please let me know what's the best course of action for the remaining issue. |
thanks @abey79 and apologies for the delay |
Description
New port for vpype, the "Swiss-Army-knife command-line tool for plotter vector graphics", including those dependencies which don't yet exist on MacPorts.
Note: this is my first port submission ever.
Type(s)
Tested on
macOS 12.2.1 21D62 arm64
Xcode 13.2.1 13C100
Verification
Have you
referenced existing tickets on Trac with full URL?port lint --nitpick
?tried existing tests withsudo port test
?sudo port -vst install
?