Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.10 compatibility and Python 3.7 deprecation #417

Merged
merged 11 commits into from
Mar 25, 2022
Merged

Python 3.10 compatibility and Python 3.7 deprecation #417

merged 11 commits into from
Mar 25, 2022

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Mar 13, 2022 •
edited
Loading

Description

Python 3.10 compatibility and Python 3.7 deprecation

TODO:

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

abey79 added 5 commits March 13, 2022 15:13
@abey79
Python 3.10 compatibility and Python 3.7 deprecation
8932ff1
@abey79
- .readthedocs.yml: updated to 3.10 and newer format
cbd19a6 
- Actions:
  - Win installer built with 3.10
  - Fixed missing quotes around 3.10
  - Updated Poetry to 1.1.13
  - Changed full pytest run to 3.10
- Updated install doc
- Updated CHANGELOG.md

- Fixed workf
@abey79
Fixed mypy errors
e9bf09a
@abey79
Updated shapely to 1.8.1.post1 (needed for python 3.10)
226fd9b
@abey79
Fixed pytest error
42e1fd6
@abey79 abey79 mentioned this pull request Mar 14, 2022
Merged
11 tasks
@abey79
- Added manual install of goes for 3.10 because the x86_64 binary of …
b48fbc4 
…shapely is not available (yet?)

- cleaned code related to viewport in viewer
@codecov
Copy link

codecov bot commented Mar 24, 2022 •
edited
Loading

Codecov Report

Merging #417 (03ada36) into master (3aee1e4) will increase coverage by 0.02%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
+ Coverage   93.75%   93.78%   +0.02%     
==========================================
  Files          59       59              
  Lines        5160     5165       +5     
  Branches      719      766      +47     
==========================================
+ Hits         4838     4844       +6     
+ Misses        207      205       -2     
- Partials      115      116       +1
Impacted Files Coverage Δ
vpype_cli/operations.py 96.71% <75.00%> (-0.36%) ⬇️
tests/test_files.py 98.77% <100.00%> (ø)
vpype_viewer/_painters.py 99.65% <100.00%> (ø)
vpype/model.py 91.75% <0.00%> (+0.02%) ⬆️
vpype_cli/substitution.py 91.40% <0.00%> (+0.06%) ⬆️
vpype/line_index.py 89.01% <0.00%> (+2.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aee1e4...03ada36. Read the comment docs.

@abey79 abey79 mentioned this pull request Mar 24, 2022
Closed
@abey79
- updated deps
3badaf2 
- pinned pyinstaller-hooks-contrib to a commit to address shapely 1.8.1
@abey79 abey79 mentioned this pull request Mar 24, 2022
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@abey79 abey79 merged commit aa8fdea into master Mar 25, 2022
@abey79 abey79 deleted the python310 branch March 25, 2022 10:32
@abey79 abey79 mentioned this pull request Mar 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abey79