Merge apache 6c130b3 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* re-enable pylint for superset/config.py * re-enable pylint on superset/migrations/env.py * re-enable pylint for superset/legacy.py * re-enable pylint for superset/forms.py * re-enable pylint for superset/stats_logger.py * Tweaks to make mypy and pylint happy * black
* re-enable pylint for superset/examples/energy.py * re-enable pylint for superset/examples/world_bank.py * re-enable pylint for superset/examples/tabbed_dashboard.py * Re-enable pylint for superset/examples/helpers.py
* re-enable pylint for superset/utils/import_datasource.py * re-enable pylint for superset/utils/cache.py * re-enable pylint for superset/utils/log.py
* Re-enable pylint for superset/db_engines/hive.py * re-enable pylint for superset/db_engine_specs/elasticsearch.py * Re-enable superset/db_engine_specs/__init__.py * Re-enable pylint for superset/db_engine_specs/exasol.py
* Re-enable pylint for superset/tasks/schedules.py * re-enable pylint for superset/tasks/celery_app.py
This should make things green here: https://whimsy.apache.org/pods/project/superset
…8769) * Limit queries * WIP * Adding unit test * WIP * Add unit test * Fix test * Try to fix remote unit tests * Fix unit test * Fix for postgres
* darker opacity on shadow for highlighted cards * removing unnecessary LESS fade * lightening the lightest segment of the shadow again.
* fix: don't show filter popover on explore view load There's this confusing "feature" that I thought was a bug that shows the metric popover opened when entering the explore view when the filter comes from an active dashboard filter, based on the "fromFormData" attribute of the filter. The popover is confusing and often shows as misaligned with the actual element it's supposed to float over when overflowing. * warn * fix cypress * also shut off metrics
* re-enable pylint for superset/common/query_context.py * Re-enable pylint for superset/connectors/base/views.py * re-enable pylint for superset/connectors/connector_registry.py * Re-enable pylint for tests/fixtures/pyodbcRow.py * re-enable pylint for superset/cli.py * Fix for mypy * Improve variable naming * A few more naming fixes
apache#8254) Resolve comments Avoid circular dependency between superset config and superset package Resolve comments
* fix: update status code for sql validator error * fix: inspect error * fix: lint issues * fix: lint issues 2
betodealmeida
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^
@betodealmeida @DiggidyDave