Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix urlib opener bug #8788

Merged
merged 1 commit into from
Dec 8, 2019
Merged

fix urlib opener bug #8788

merged 1 commit into from
Dec 8, 2019

Conversation

blcksrx
Copy link
Contributor

@blcksrx blcksrx commented Dec 7, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

urllib opener does not have any method called content and for getting the content of the response should invoke read() method.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

REVIEWERS

@codecov-io
Copy link

codecov-io commented Dec 7, 2019

Codecov Report

Merging #8788 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8788      +/-   ##
==========================================
+ Coverage   65.83%   65.83%   +<.01%     
==========================================
  Files         482      482              
  Lines       24155    24156       +1     
  Branches     2770     2770              
==========================================
+ Hits        15903    15904       +1     
  Misses       8074     8074              
  Partials      178      178
Impacted Files Coverage Δ
superset/tasks/schedules.py 80% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed3944e...4c4b4d3. Read the comment docs.

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature was community contributed and isn't actively used by the committers. Merging

@mistercrunch mistercrunch merged commit b053d66 into apache:master Dec 8, 2019
@blcksrx
Copy link
Contributor Author

blcksrx commented Dec 8, 2019

This feature was community contributed and isn't actively used by the committers. Merging

It's really a good feature

@blcksrx blcksrx deleted the email branch December 8, 2019 06:19
varunbargali pushed a commit to chqbook/incubator-superset that referenced this pull request Feb 24, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants