Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import LXD changes #226

Merged
merged 37 commits into from
Nov 11, 2023
Merged

Import LXD changes #226

merged 37 commits into from
Nov 11, 2023

Commits on Nov 11, 2023

  1. [lxd-import] metrics: Fix label merging in metric sets 

    This changes the Merge function to apply any missing labels from the
receiver to all samples from the argument.

This fixes an issue where filesystem stats would be missing certain
labels which were not explicitly set for the filesystem stats metric
set.

Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
    @monstermunchkin @stgraber
    monstermunchkin authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    270d316 View commit details
    Browse the repository at this point in the history

  2. [lxd-import] test: Check instance type in filesystem metrics 

    Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
    @monstermunchkin @stgraber
    monstermunchkin authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    df66d6e View commit details
    Browse the repository at this point in the history

  3. [lxd-import] test/includes/certificates: add gen_cert_and_key() 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    363f1f3 View commit details
    Browse the repository at this point in the history

  4. [lxd-import] test/metrics: use gen_cert_and_key function instead of d… 

    …irectly calling openssl

This switches from RSA/2048 to ECDSA using the P-384 curve.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    f0b6069 View commit details
    Browse the repository at this point in the history

  5. [lxd-import] test/remote: use gen_cert_and_key function instead of di… 

    …rectly calling openssl

This switches from RSA/2048 to ECDSA using the P-384 curve.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    bad53be View commit details
    Browse the repository at this point in the history

  6. [lxd-import] test/tls_restrictions: add some double quotes 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    d3a8274 View commit details
    Browse the repository at this point in the history

  7. [lxd-import] test/tls_restrictions: fix some comments 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    727e03a View commit details
    Browse the repository at this point in the history

  8. [lxd-import] test/tls_restrictions: make sure expected failures get t… 

    …he expected 403

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    14f235f View commit details
    Browse the repository at this point in the history

  9. [lxd-import] test/tls_restrictions: use gen_cert_and_key function ins… 

    …tead of directly calling openssl

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    4826a3e View commit details
    Browse the repository at this point in the history

  10. [lxd-import] test/tls_restrictions: ensure type=metrics certificates … 

    …cannot access anything besides /1.0/metrics.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    e5ea42d View commit details
    Browse the repository at this point in the history

  11. [lxd-import] lxd/device/proxy: Consider routed NIC IPs for wildcard t… 

    …arget check

These too are reachable from the host, just like bridged NIC ones.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
    @tomponline @stgraber
    tomponline authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    2c65ab2 View commit details
    Browse the repository at this point in the history

  12. [lxd-import] lxd/network/driver/bridge: Improve comments for accept_ra 

    Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
    @tomponline @stgraber
    tomponline authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    aec500e View commit details
    Browse the repository at this point in the history

  13. [lxd-import] config: Restrict user.* keys 

    This restricts user.* keys to only allow letters, digits, and
punctuation characters.

Fixes #12308

Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
    @monstermunchkin @stgraber
    monstermunchkin authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    c9612b5 View commit details
    Browse the repository at this point in the history

  14. [lxd-import] test: Validate user.* keys 

    Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
    @monstermunchkin @stgraber
    monstermunchkin authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    d40f730 View commit details
    Browse the repository at this point in the history

  15. [lxd-import] github: Use Go 1.20 and check for compat with that in go… 

    … mod tidy

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    d7049d4 View commit details
    Browse the repository at this point in the history

  16. [lxd-import] github: Removes whitespace 

    Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
    @tomponline @stgraber
    tomponline authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    80e8271 View commit details
    Browse the repository at this point in the history

  17. [lxd-import] lxd/incus-doc: Remove noisy log line 

    Otherwise it logs a line for every non-Go file!

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
    @tomponline @stgraber
    tomponline authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    9071108 View commit details
    Browse the repository at this point in the history

  18. [lxd-import] test/lint: Removes openfga model linter. 

    We will need to have multiple models so that we can figure out our
current version and migrate from one to the next. So it doesn't make
sense to ask if a model is "up to date", because they are immutable.

Signed-off-by: Mark Laing <mark.laing@canonical.com>
    @markylaing @stgraber
    markylaing authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    1894254 View commit details
    Browse the repository at this point in the history

  19. [lxd-import] test/basic: always use -- with incus exec 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    647758e View commit details
    Browse the repository at this point in the history

  20. [lxd-import] test/basic: test with and without "--" separator 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    4337c1c View commit details
    Browse the repository at this point in the history

  21. [lxd-import] test/clustering: always use -- with incus exec 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    477d7c1 View commit details
    Browse the repository at this point in the history

  22. [lxd-import] test/config: always use -- with incus exec 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    a815cea View commit details
    Browse the repository at this point in the history

  23. [lxd-import] test/dev-incus: always use -- with incus exec 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    9dea47f View commit details
    Browse the repository at this point in the history

  24. [lxd-import] test/image_acl: always use -- with incus exec 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    cf303b8 View commit details
    Browse the repository at this point in the history

  25. [lxd-import] test/storage_snapshots: always use -- with incus exec 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    b039833 View commit details
    Browse the repository at this point in the history

  26. [lxd-import] doc/howto/network_ovn_setup: always use -- with `incus e… 

    …xec`

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    1619b68 View commit details
    Browse the repository at this point in the history

  27. [lxd-import] doc/howto/instances_troubleshoot: always use -- with `lx… 

    …c exec`

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    c69d5bd View commit details
    Browse the repository at this point in the history

  28. [lxd-import] lxd/dev-incus: always use -- with incus exec 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    3ed8c3a View commit details
    Browse the repository at this point in the history

  29. [lxd-import] doc/requirements: allow linking to Go requirements 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    c9314c8 View commit details
    Browse the repository at this point in the history

  30. [lxd-import] doc/installing: link to Go requirements and update Ubunt… 

    …u instructions

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    5670c23 View commit details
    Browse the repository at this point in the history

  31. [lxd-import] doc/howto/benchmark_performance: link to Go requirements 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    53c4849 View commit details
    Browse the repository at this point in the history

  32. [lxd-import] doc/howto/migrate_from_lxc: link to Go requirements 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    b48d332 View commit details
    Browse the repository at this point in the history

  33. [lxd-import] doc/requirements: Go 1.20 is now the minimum version 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    2766dde View commit details
    Browse the repository at this point in the history

  34. [lxd-import] shared/cert: Update code comments about CRL 

    Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    4dd424b View commit details
    Browse the repository at this point in the history

  35. [lxd-import] lxd/util/http: Check if the CRL was signed by the CA bef… 

    …ore using it

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
    @simondeziel @stgraber
    simondeziel authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    a0d9779 View commit details
    Browse the repository at this point in the history

  36. [lxd-import] lxc/delete: Include instance name in error message 

    When deleting multiple instances at once, it's not clear which deletion
failed as the instance name is not included in the error message.

This adds the instance name to the error message.

Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
    @monstermunchkin @stgraber
    monstermunchkin authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    d91b9dd View commit details
    Browse the repository at this point in the history

  37. [lxd-import] Update translations 

    Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
    @monstermunchkin @stgraber
    monstermunchkin authored and stgraber committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    e02e36f View commit details
    Browse the repository at this point in the history