Import LXD changes #226
Merged
Import LXD changes #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the Merge function to apply any missing labels from the receiver to all samples from the argument. This fixes an issue where filesystem stats would be missing certain labels which were not explicitly set for the filesystem stats metric set. Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…irectly calling openssl This switches from RSA/2048 to ECDSA using the P-384 curve. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…rectly calling openssl This switches from RSA/2048 to ECDSA using the P-384 curve. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…he expected 403 Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…tead of directly calling openssl Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…cannot access anything besides /1.0/metrics. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…arget check These too are reachable from the host, just like bridged NIC ones. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
This restricts user.* keys to only allow letters, digits, and punctuation characters. Fixes #12308 Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
… mod tidy Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com> Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Otherwise it logs a line for every non-Go file! Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
We will need to have multiple models so that we can figure out our current version and migrate from one to the next. So it doesn't make sense to ask if a model is "up to date", because they are immutable. Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…xec` Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…c exec` Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…u instructions Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…ore using it Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
When deleting multiple instances at once, it's not clear which deletion failed as the instance name is not included in the error message. This adds the instance name to the error message. Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.