Restructure filtering and add new filters (v2) #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
This changes the way filters are applied. Prior to this change, filters were applied in various places. With this change, all filters are applied at start by modifying the loaded definition. Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
|
@monstermunchkin can you describe what was the problem with the previous attempt? |
|
When calling When LXC target filtering was added, all targets in our yaml files were ignored because no type filter was set ( However, for these targets it doesn't make sense explicitly setting the type filter. Instead, the targets will now also be included if no type filter is set. We therefore don't need to change our image files. I hope that explains the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially the same as PR #744 but fixes LXC target filtering.