Restructure filtering and add new filters #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monstermunchkin
force-pushed
the
issues/742-filters
branch
from
6eead6f
to
515942a
Compare
simondeziel
reviewed
Jul 4, 2023
monstermunchkin
force-pushed
the
issues/742-filters
branch
2 times, most recently
from
191ee50
to
d0ed381
Compare
monstermunchkin
requested review from
simondeziel and
stgraber
and removed request for
simondeziel
simondeziel
reviewed
Jul 6, 2023
OK, but you've been doing a good job so far with your Go reviews 😉 |
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
This changes the way filters are applied. Prior to this change, filters were applied in various places. With this change, all filters are applied at start by modifying the loaded definition. Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
monstermunchkin
force-pushed
the
issues/742-filters
branch
from
d0ed381
to
2e6a1a1
Compare
|
With this PR, meta.tar.xz ends up not having config.* or templates. If the fix is simple, let's do that, but it's probably best to revert this PR for now, as lxc-create -t download is broken for the world right now. |
|
Hi - when you resubmit this, it would be great if you could add a test in the github actions workflow which does a pack-lxc and verifies that the required files are generated in meta.tar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #742