Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about specTranslation params #847

Closed
borongyuan opened this issue Jun 13, 2023 · 2 comments
Closed

Question about specTranslation params #847

borongyuan opened this issue Jun 13, 2023 · 2 comments

Comments

@borongyuan
Copy link

The release note of v2.21.2 mentioned:

Added disparityToDepthUseSpecTranslation, rectificationUseSpecTranslation, and depthAlignmentUseSpecTranslation options for advanced usage

Looks like their default values are:

bool disparityToDepthUseSpecTranslation = true;
bool rectificationUseSpecTranslation = false;
bool depthAlignmentUseSpecTranslation = true;

I don't understand why calibration data is not used as default for disparityToDepth and depthAlignment.
Not sure if these are related to #840. I didn't see a noticeable effect in my tests.

@Erol444
Copy link
Member

Erol444 commented Jun 20, 2023

Hi @borongyuan , I believe it really depends on the calibration quality. Usually, you will have more accurate translation if you look at specs (CAD model) than the one obtained from camera matrix. But for rectification we found that we obtained better results if we took extrinsics from calibration.

@borongyuan
Copy link
Author

Thanks, I get it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants