-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fedekunze/1917 handle ledger disconnection & rejection #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kunze/1917-check-ledger-connection
…kunze/1917-check-ledger-connection
Codecov Report
@@ Coverage Diff @@
## develop #2005 +/- ##
==========================================
- Coverage 94.91% 94.9% -0.02%
==========================================
Files 121 121
Lines 2637 2651 +14
Branches 123 123
==========================================
+ Hits 2503 2516 +13
- Misses 125 126 +1
Partials 9 9
|
Codecov Report
@@ Coverage Diff @@
## develop #2005 +/- ##
===========================================
+ Coverage 94.85% 94.86% +<.01%
===========================================
Files 120 119 -1
Lines 2586 2591 +5
Branches 123 121 -2
===========================================
+ Hits 2453 2458 +5
Misses 124 124
Partials 9 9
|
Nice. I think this needs a design revamp @jbibla |
faboweb
reviewed
Feb 19, 2019
faboweb
reviewed
Feb 19, 2019
8 tasks
jbibla
reviewed
Feb 19, 2019
jbibla
reviewed
Feb 19, 2019
jbibla
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1917
Closes #1978
Closes #2016
Description:
LedgerSession
ActionModal
Signature rejection
Thank you! 🚀
For contributor:
CHANGELOG.md
with issue # and GitHub usernameFiles changed
in the github PR explorerFor reviewer: