Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedekunze/1917 handle ledger disconnection & rejection #2005

Merged
merged 19 commits into from
Feb 20, 2019

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Feb 18, 2019

Closes #1917
Closes #1978
Closes #2016

Description:

LedgerSession

screen shot 2019-02-19 at 12 09 15 pm

ActionModal

screen shot 2019-02-18 at 5 50 29 pm

screen shot 2019-02-18 at 5 50 50 pm

Signature rejection

screen shot 2019-02-19 at 4 50 45 pm

Thank you! 🚀


For contributor:

  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #2005 into develop will decrease coverage by 0.01%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##           develop   #2005      +/-   ##
==========================================
- Coverage    94.91%   94.9%   -0.02%     
==========================================
  Files          121     121              
  Lines         2637    2651      +14     
  Branches       123     123              
==========================================
+ Hits          2503    2516      +13     
- Misses         125     126       +1     
  Partials         9       9
Impacted Files Coverage Δ
...c/renderer/components/common/TmSessionHardware.vue 100% <100%> (ø) ⬆️
app/src/renderer/vuex/modules/ledger.js 100% <100%> (ø) ⬆️
app/src/renderer/vuex/modules/send.js 98.24% <75%> (-1.76%) ⬇️

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #2005 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2005      +/-   ##
===========================================
+ Coverage    94.85%   94.86%   +<.01%     
===========================================
  Files          120      119       -1     
  Lines         2586     2591       +5     
  Branches       123      121       -2     
===========================================
+ Hits          2453     2458       +5     
  Misses         124      124              
  Partials         9        9
Impacted Files Coverage Δ
...rc/renderer/components/common/TmSessionLoading.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/common/ActionModal.vue 100% <ø> (ø) ⬆️
app/src/renderer/vuex/modules/send.js 100% <100%> (ø) ⬆️
app/src/renderer/vuex/modules/ledger.js 100% <100%> (ø) ⬆️
...c/renderer/components/common/TmSessionHardware.vue 100% <100%> (ø) ⬆️

@fedekunze fedekunze marked this pull request as ready for review February 19, 2019 11:59
@faboweb
Copy link
Collaborator

faboweb commented Feb 19, 2019

Nice. I think this needs a design revamp @jbibla

@faboweb faboweb mentioned this pull request Feb 19, 2019
8 tasks
@fedekunze fedekunze changed the title fedekunze/1917 handle ledger disconnection fedekunze/1917 handle ledger disconnection & rejection Feb 19, 2019
Federico Kunze added 3 commits February 19, 2019 17:42
@jbibla jbibla merged commit d27a777 into develop Feb 20, 2019
@jbibla jbibla deleted the fedekunze/1917-check-ledger-connection branch February 20, 2019 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants