Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature rejection with Ledger #2016

Closed
fedekunze opened this issue Feb 19, 2019 · 1 comment · Fixed by #2005
Closed

Signature rejection with Ledger #2016

fedekunze opened this issue Feb 19, 2019 · 1 comment · Fixed by #2005
Assignees
@fedekunze
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed ledger 👨‍💻 Issues related to Ledger Nano S

Comments

@fedekunze
Copy link
Contributor

UI Version: 0.X.X

Description:

We're not handling the case when the user rejects the transaction on the ledger, which results in an error: signature is not a Buffer
@fedekunze fedekunze added bug 🐛 issues related to unhandled errors in the code that need to be fixed ledger 👨‍💻 Issues related to Ledger Nano S labels Feb 19, 2019
@fedekunze fedekunze self-assigned this Feb 19, 2019
fedekunze pushed a commit that referenced this issue Feb 19, 2019
handle signature rejection; closes #2016
1f19e43
@fedekunze fedekunze mentioned this issue Feb 19, 2019
Merged
5 tasks
@jbibla
Copy link
Collaborator

jbibla commented Feb 20, 2019

good call. should be a nicer error message and can include something like "transaction rejected".

jbibla pushed a commit that referenced this issue Feb 20, 2019
@fedekunze @jbibla
fedekunze/1917 handle ledger disconnection & rejection (#2005)
d27a777 
* handle ledger disconnection

* update session tests

* update package.json

* ledger module tests

* changelog

* update tests

* fix tests and loader

* handle signature rejection; closes #2016

* changelog

* snaps

* CI

* more snaps

* nbsp

* lint

* nbsp 2

* revert latest lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedekunze fedekunze

Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed ledger 👨‍💻 Issues related to Ledger Nano S
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fedekunze/1917 handle ledger disconnection & rejection luniehq/lunie
2 participants
@jbibla @fedekunze