Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client_just_disconnected condition logic #99

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Fix client_just_disconnected condition logic #99

merged 1 commit into from
Aug 2, 2023

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Jul 22, 2023

I screwed the logic in #96. We shouldn't just return true if transport is not found, we should compare it with previous one. And we should store just_connected state instead of just_disconnected because the default value of this param is false.
I also updated client_just_connected to make it look similar.

@lucaspoffo lucaspoffo changed the title Fox client_just_disconnected condition logic Fix client_just_disconnected condition logic Jul 23, 2023
@lucaspoffo lucaspoffo self-requested a review July 31, 2023 16:36
@lucaspoffo lucaspoffo merged commit 6dd55d2 into lucaspoffo:master Aug 2, 2023
@lucaspoffo
Copy link
Owner

Thanks!

@Shatur Shatur deleted the fix-conditions branch August 2, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants