Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return closures from conditions #96

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Return closures from conditions #96

merged 3 commits into from
Jul 20, 2023

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Jul 18, 2023

In Bevy all conditions done this way. See the the example. Let's make them consistent with the rest of the engine.

Shatur added 2 commits July 18, 2023 12:11
In Bevy all conditions done this way, let's make them consistent with
the rest of the engine.
@Shatur
Copy link
Contributor Author

Shatur commented Jul 18, 2023

Added two more condition that should replace #95. Similar to https://docs.rs/bevy/latest/bevy/input/struct.Input.html#method.just_pressed.

@lucaspoffo lucaspoffo self-requested a review July 18, 2023 23:54
@lucaspoffo
Copy link
Owner

Added two more condition that should replace #95. Similar to https://docs.rs/bevy/latest/bevy/input/struct.Input.html#method.just_pressed.

Yeah, I prefer doing like this instead of events 👍

@Shatur Shatur requested a review from lucaspoffo July 19, 2023 00:15
@lucaspoffo lucaspoffo merged commit 114a226 into lucaspoffo:master Jul 20, 2023
@lucaspoffo
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants