Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPM spec file cleanup #141

Closed
davidcoutadeur opened this issue Jul 18, 2024 · 1 comment · Fixed by #155
Closed

RPM spec file cleanup #141

davidcoutadeur opened this issue Jul 18, 2024 · 1 comment · Fixed by #155
Assignees
@davidcoutadeur
Labels
packaging
Milestone
0.6

Comments

@davidcoutadeur
Copy link

The idea is to do the same thing as what have been done in self-service-password:
@davidcoutadeur davidcoutadeur added the enhancement New feature or request label Jul 18, 2024
@davidcoutadeur davidcoutadeur added this to the 0.6 milestone Jul 18, 2024
@davidcoutadeur davidcoutadeur self-assigned this Jul 18, 2024
davidcoutadeur pushed a commit that referenced this issue Jul 25, 2024
@xavierba
clean specfile (#141)
524393d 
Drop deprecated Group and BuildRoot tags
Don't clean buildroot at start of %%install and drop %%clean section
Re-order preamble and drop useless variables
Use %%global instead of %%define
Split long line in %%description
Split long lines / simplify
Don't change dirs ownership in %%post
Drop default %%defattr
Convert License tag to SPDX and distribute LICENSE file
Distribute AUTHORS and README.md
Move conf file to %%_sysconfdir
Use macros instead of straigh paths
Drop comments duplicating sections name
Add blank lines between changelog entries for legibility
Fix changelog entries format
Use full URL for Source0
Add provides for bundled stuff
Run checks (Fedora only)
Specify all deps and provide a custom autoloader
Specify min php version
Install a minimal local config
Re-order directories creation
Preserve timestamps
Update URL tag
davidcoutadeur pushed a commit that referenced this issue Jul 25, 2024
clean composer dependencies and specfile (#141)
e86a72c 
* remove all files in htdocs/vendor/ except i18n in datatables,
  because they'll be managed by composer
* add .gitignore in htdocs/vendor/ to ensure no files would be tracked
  there except for htdocs/vendor/datatables/i18n
* improve composer.json file to clean the downloaded dependencies and
  keep only the required files in htdocs/vendor
* clean specfile: add bundled dependencies, remove custom autoload and
  local config file, manage the config file migration to /etc/service-desk
@davidcoutadeur davidcoutadeur added packaging and removed enhancement New feature or request labels Jul 25, 2024
@davidcoutadeur davidcoutadeur mentioned this issue Jul 25, 2024
Merged
davidcoutadeur pushed a commit that referenced this issue Jul 25, 2024
clean composer dependencies and specfile (#141)
d9b5875 
* remove all files in htdocs/vendor/ except i18n in datatables,
  because they'll be managed by composer
* add .gitignore in htdocs/vendor/ to ensure no files would be tracked
  there except for htdocs/vendor/datatables/i18n
* improve composer.json file to clean the downloaded dependencies and
  keep only the required files in htdocs/vendor
* clean specfile: add bundled dependencies, remove custom autoload and
  local config file, manage the config file migration to /etc/service-desk,
  clean hidden files in bundled php libs
@davidcoutadeur
Copy link
Author

davidcoutadeur commented Jul 25, 2024 •
edited
Loading

Here is the list of breaking change in the #155 PR, which must be brought to .deb package, and notified in the changelog / in the release notes / documentation:

  • the dependencies are now explicitly listed in the RPM, including the bundled ones.
  • the configuration files are now in /etc/service-desk directory
  • the previous configuration files present in /usr/share/service-desk/conf (all .php files) are migrated to /etc/service-desk/ during the upgrade process. config.inc.php is migrated as a config.inc.php.bak file, all other php file names are preserved.
  • smarty is now a required package. See consideration about smarty 3 / smarty 4 in this issue opened in self-service-password project: Update to smarty4 self-service-password#850
  • some bundled dependencies have been updated:
        "components/jquery": "v3.7.1",
        "datatables.net/datatables.net-bs5": "2.0.8",
        "datatables.net/datatables.net-buttons-bs5": "3.0.2",
        "fortawesome/font-awesome": "v6.5.2",
        "ltb-project/ltb-common": "0.3.0",
        "twbs/bootstrap": "v5.3.2"
  • a minimum version of PHP is now required by the package: >=7.3
  • new basic dependencies are now required by the package: php-fpm, coreutils
  • hidden files (.gitignore,...) from bundled dependencies are now removed from the package
  • now, the cache is being cleaned-up during self-service-password upgrade / install

davidcoutadeur pushed a commit that referenced this issue Jul 31, 2024
@xavierba
clean specfile (#141)
ad00342 
Drop deprecated Group and BuildRoot tags
Don't clean buildroot at start of %%install and drop %%clean section
Re-order preamble and drop useless variables
Use %%global instead of %%define
Split long line in %%description
Split long lines / simplify
Don't change dirs ownership in %%post
Drop default %%defattr
Convert License tag to SPDX and distribute LICENSE file
Distribute AUTHORS and README.md
Move conf file to %%_sysconfdir
Use macros instead of straigh paths
Drop comments duplicating sections name
Add blank lines between changelog entries for legibility
Fix changelog entries format
Use full URL for Source0
Add provides for bundled stuff
Run checks (Fedora only)
Specify all deps and provide a custom autoloader
Specify min php version
Install a minimal local config
Re-order directories creation
Preserve timestamps
Update URL tag
davidcoutadeur pushed a commit that referenced this issue Jul 31, 2024
clean composer dependencies and specfile (#141)
9241a37 
* remove all files in htdocs/vendor/ except i18n in datatables,
  because they'll be managed by composer
* add .gitignore in htdocs/vendor/ to ensure no files would be tracked
  there except for htdocs/vendor/datatables/i18n
* improve composer.json file to clean the downloaded dependencies and
  keep only the required files in htdocs/vendor
* clean specfile: add bundled dependencies, remove custom autoload and
  local config file, manage the config file migration to /etc/service-desk,
  clean hidden files in bundled php libs
davidcoutadeur pushed a commit that referenced this issue Jul 31, 2024
clean composer dependencies and specfile (#141)
b67ccb9 
* remove all files in htdocs/vendor/ except i18n in datatables,
  because they'll be managed by composer
* add .gitignore in htdocs/vendor/ to ensure no files would be tracked
  there except for htdocs/vendor/datatables/i18n
* improve composer.json file to clean the downloaded dependencies and
  keep only the required files in htdocs/vendor
* clean specfile: add bundled dependencies, remove custom autoload and
  local config file, manage the config file migration to /etc/service-desk,
  clean hidden files in bundled php libs, fix license filename
davidcoutadeur pushed a commit that referenced this issue Jul 31, 2024
clean composer dependencies and specfile (#141)
8c6faee 
* remove all files in htdocs/vendor/ except i18n in datatables,
  because they'll be managed by composer
* add .gitignore in htdocs/vendor/ to ensure no files would be tracked
  there except for htdocs/vendor/datatables/i18n
* improve composer.json file to clean the downloaded dependencies and
  keep only the required files in htdocs/vendor
* clean specfile: add bundled dependencies, remove custom autoload and
  local config file, manage the config file migration to /etc/service-desk,
  clean hidden files in bundled php libs, fix license filename,
  add missing htdocs/js directory
davidcoutadeur pushed a commit that referenced this issue Jul 31, 2024
clean composer dependencies and specfile (#141)
b2bf612 
* remove all files in htdocs/vendor/ except i18n in datatables,
  because they'll be managed by composer
* add .gitignore in htdocs/vendor/ to ensure no files would be tracked
  there except for htdocs/vendor/datatables/i18n
* improve composer.json file to clean the downloaded dependencies and
  keep only the required files in htdocs/vendor
* clean specfile: add bundled dependencies, remove custom autoload and
  local config file, manage the config file migration to /etc/service-desk,
  clean hidden files in bundled php libs, fix license filename,
  add missing htdocs/js directory
davidcoutadeur pushed a commit that referenced this issue Jul 31, 2024
clean composer dependencies and specfile (#141)
5083980 
* remove all files in htdocs/vendor/ except i18n in datatables,
  because they'll be managed by composer
* add .gitignore in htdocs/vendor/ to ensure no files would be tracked
  there except for htdocs/vendor/datatables/i18n
* improve composer.json file to clean the downloaded dependencies and
  keep only the required files in htdocs/vendor
* clean specfile: add bundled dependencies, remove custom autoload and
  local config file, manage the config file migration to /etc/service-desk,
  clean hidden files in bundled php libs, fix license filename,
  add missing htdocs/js directory
davidcoutadeur pushed a commit that referenced this issue Jul 31, 2024
clean composer dependencies and specfile (#141)
9830794 
* remove all files in htdocs/vendor/ except i18n in datatables,
  because they'll be managed by composer
* add .gitignore in htdocs/vendor/ to ensure no files would be tracked
  there except for htdocs/vendor/datatables/i18n
* improve composer.json file to clean the downloaded dependencies and
  keep only the required files in htdocs/vendor
* clean specfile: add bundled dependencies, remove custom autoload and
  local config file, manage the config file migration to /etc/service-desk,
  clean hidden files in bundled php libs, fix license filename,
  add missing htdocs/js directory, remove httpd and add php-fpm dependency
davidcoutadeur pushed a commit that referenced this issue Jul 31, 2024
@xavierba @davidcoutadeur
clean specfile (#141)
c5e6524 
Drop deprecated Group and BuildRoot tags
Don't clean buildroot at start of %%install and drop %%clean section
Re-order preamble and drop useless variables
Use %%global instead of %%define
Split long line in %%description
Split long lines / simplify
Don't change dirs ownership in %%post
Drop default %%defattr
Convert License tag to SPDX and distribute LICENSE file
Distribute AUTHORS and README.md
Move conf file to %%_sysconfdir
Use macros instead of straigh paths
Drop comments duplicating sections name
Add blank lines between changelog entries for legibility
Fix changelog entries format
Use full URL for Source0
Add provides for bundled stuff
Run checks (Fedora only)
Specify all deps and provide a custom autoloader
Specify min php version
Install a minimal local config
Re-order directories creation
Preserve timestamps
Update URL tag
davidcoutadeur pushed a commit that referenced this issue Jul 31, 2024
@davidcoutadeur
clean composer dependencies and specfile (#141)
cc3601d 
* remove all files in htdocs/vendor/ except i18n in datatables,
  because they'll be managed by composer
* add .gitignore in htdocs/vendor/ to ensure no files would be tracked
  there except for htdocs/vendor/datatables/i18n
* improve composer.json file to clean the downloaded dependencies and
  keep only the required files in htdocs/vendor
* clean specfile: add bundled dependencies, remove custom autoload and
  local config file, manage the config file migration to /etc/service-desk,
  clean hidden files in bundled php libs, fix license filename,
  add missing htdocs/js directory, remove httpd and add php-fpm dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidcoutadeur davidcoutadeur

Labels
packaging
Projects
None yet
Milestone
0.6
Development

Successfully merging a pull request may close this issue.

141 rpm spec file cleanup ltb-project/service-desk
1 participant
@davidcoutadeur