Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to smarty4 #850

Closed
davidcoutadeur opened this issue Mar 8, 2024 · 5 comments
Closed

Update to smarty4 #850

davidcoutadeur opened this issue Mar 8, 2024 · 5 comments
Assignees
Milestone

Comments

@davidcoutadeur
Copy link

Some time ago (see #773) we decided to remove smarty3 from direct dependencies, because

1/ it was broken on ubuntu (https://bugs.launchpad.net/ubuntu/+source/smarty3/+bug/1986916) and
2/ it was unavailable on some rh-like systems

I think it is interesting to now consider the upgrade to smarty4, for multiple reasons:

  • smarty4 is released since 2021. It is now considered as the stable version. smarty3 is now only recommended for applications requiring PHP < 7.1
  • smarty4 seems well-packaged on multiple systems (tested and working on debian 12)
  • we could simplify installation process by simply enabling smarty4 as a requirement in rpm/deb packages
@davidcoutadeur davidcoutadeur self-assigned this Mar 8, 2024
@davidcoutadeur davidcoutadeur added this to the 1.6.0 milestone Mar 8, 2024
@coudot
Copy link
Member

coudot commented Mar 8, 2024

We also need to see if Smarty is a system dependency or a composer dependency

@davidcoutadeur
Copy link
Author

davidcoutadeur commented Mar 8, 2024

We also need to see if Smarty is a system dependency or a composer dependency

smarty4 is a system dependency on debian.

@xavierba is working on a smarty4 package on rh-like systems

This was referenced Mar 8, 2024
@davidcoutadeur
Copy link
Author

davidcoutadeur commented Mar 12, 2024

NOTE: When (if) updating requirement to smarty4, we must also list the new version in deb package (replacement of smarty path in config files in debian/replace_cache_dirs + Depends: in control file) and in RPM package (replacement of smarty path in config files + requirement of smarty package)

@davidcoutadeur
Copy link
Author

smarty4 is not available on debian 11 and debian 10.

We may require it with as a OR dependency: smarty4|smarty3 (with a preference for smarty4)

@coudot
Copy link
Member

coudot commented Apr 19, 2024

php-Smarty 4 not yet available on EPEL/Fedora, but as we don't require explicitely v3, it will use Smarty 4 as soon it is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants