-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Support Pyris V2
#8286
Conversation
# Conflicts: # src/main/java/de/tum/in/www1/artemis/domain/quiz/DragAndDropQuestion.java # src/test/java/de/tum/in/www1/artemis/service/programming/ProgrammingExerciseFeedbackCreationServiceTest.java
- join column defined in collection table - element collection always cascading
src/main/java/de/tum/in/www1/artemis/service/connectors/pyris/job/TutorChatJob.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/iris/websocket/IrisWebsocketDTO.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/iris/websocket/IrisWebsocketDTO.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my feedback. I only have some minor questions / comments left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Out of diff range and nitpick comments (1)
src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisChatSessionService.java (1)
20-28
: Consider organizing imports to improve readability and maintainability.
src/main/java/de/tum/in/www1/artemis/service/iris/session/IrisChatSessionService.java
Show resolved
Hide resolved
fdeeca0
to
1490ce8
Compare
Checklist
General
Server
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
The Iris WG has come to the conclusion that PyrisV1, which was based on guidance, is no longer the best way forward for Iris. So we decided that we should replace it with a new version called PyrisV2.
For this the entire Pyris Connector and the way responses are handled needs to be replaced in Artemis. This PR implements the first steps for proper PyrisV2 support.
Description
There are numerous changes that were needed:
The client will get some further changes in a future PR by @bassner.
The other features of Iris will be reenabled in future PRs.
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Coverage
Client
Server
�