-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iris
: Add chat in text exercises
#9362
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
…cise-support # Conflicts: # src/main/java/de/tum/cit/aet/artemis/iris/domain/session/IrisTextExerciseChatSession.java # src/main/java/de/tum/cit/aet/artemis/iris/domain/settings/IrisTextExerciseChatSubSettings.java # src/main/java/de/tum/cit/aet/artemis/iris/dto/IrisCombinedTextExerciseChatSubSettingsDTO.java # src/main/java/de/tum/cit/aet/artemis/iris/repository/IrisTextExerciseChatSessionRepository.java # src/main/java/de/tum/cit/aet/artemis/iris/service/IrisSessionService.java # src/main/java/de/tum/cit/aet/artemis/iris/service/pyris/PyrisStatusUpdateService.java # src/main/java/de/tum/cit/aet/artemis/iris/service/pyris/dto/data/PyrisTextExerciseDTO.java # src/main/java/de/tum/cit/aet/artemis/iris/service/pyris/job/TextExerciseChatJob.java # src/main/java/de/tum/cit/aet/artemis/iris/service/session/IrisTextExerciseChatSessionService.java # src/main/java/de/tum/cit/aet/artemis/iris/service/settings/IrisSubSettingsService.java # src/main/java/de/tum/cit/aet/artemis/iris/web/IrisSettingsResource.java # src/main/java/de/tum/cit/aet/artemis/iris/web/IrisTextExerciseChatSessionResource.java # src/main/java/de/tum/cit/aet/artemis/iris/web/open/PublicPyrisStatusUpdateResource.java # src/main/webapp/app/exercises/text/participate/text-editor.component.ts # src/test/java/de/tum/cit/aet/artemis/iris/AbstractIrisIntegrationTest.java # src/test/java/de/tum/cit/aet/artemis/iris/IrisTextExerciseChatMessageIntegrationTest.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good code. Couple of suggestions
src/main/java/de/tum/cit/aet/artemis/iris/service/pyris/dto/data/PyrisTextExerciseDTO.java
Outdated
Show resolved
Hide resolved
src/test/java/de/tum/cit/aet/artemis/iris/AbstractIrisIntegrationTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coder looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The base branch was changed.
# Conflicts: # src/main/java/de/tum/cit/aet/artemis/iris/domain/settings/IrisCourseSettings.java # src/main/java/de/tum/cit/aet/artemis/iris/domain/settings/IrisExerciseSettings.java # src/main/java/de/tum/cit/aet/artemis/iris/domain/settings/IrisGlobalSettings.java # src/main/java/de/tum/cit/aet/artemis/iris/domain/settings/IrisSubSettingsType.java # src/main/java/de/tum/cit/aet/artemis/iris/dto/IrisCombinedSettingsDTO.java # src/main/java/de/tum/cit/aet/artemis/iris/service/IrisSessionService.java # src/main/java/de/tum/cit/aet/artemis/iris/service/settings/IrisSettingsService.java # src/main/java/de/tum/cit/aet/artemis/iris/service/settings/IrisSubSettingsService.java # src/main/java/de/tum/cit/aet/artemis/iris/web/IrisSettingsResource.java # src/main/java/de/tum/cit/aet/artemis/iris/web/IrisVariantsResource.java # src/main/webapp/app/entities/iris/settings/iris-settings.model.ts # src/main/webapp/app/entities/iris/settings/iris-sub-settings.model.ts # src/main/webapp/app/iris/settings/iris-settings-update/iris-settings-update.component.html # src/main/webapp/app/iris/settings/iris-settings-update/iris-settings-update.component.ts # src/main/webapp/i18n/de/iris.json # src/test/java/de/tum/cit/aet/artemis/iris/AbstractIrisIntegrationTest.java # src/test/java/de/tum/cit/aet/artemis/iris/settings/IrisSettingsIntegrationTest.java # src/test/javascript/spec/component/iris/settings/iris-course-settings-update.component.spec.ts # src/test/javascript/spec/component/iris/settings/iris-enabled.component.spec.ts # src/test/javascript/spec/component/iris/settings/iris-exercise-settings-update.component.spec.ts # src/test/javascript/spec/component/iris/settings/iris-global-settings-update.component.spec.ts
Iris
: Add Iris chat in text exercisesIris
: Add chat in text exercises
Checklist
General
Server
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
Up until now, Iris has only been available for programming exercises. We want to expand the availability of Iris to other exercise types.
Description
Iris has been added to text exercises.
Future Work
In this PR, Iris is only aware of the last submission to the exercise. If the user edits the text without submitting, Iris will not see it. This is because it is not possible with the current server architecture for the client to send form data for use in the Pyris feature pipeline. This is outside the scope of this PR.
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test
Performance Tests
Test Coverage
Screenshots
Summary by CodeRabbit
New Features
IrisTextExerciseChatSession
for managing chat sessions related to text exercises.Bug Fixes
Documentation
Chores