-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Update json backup tool for new features #2667
Conversation
Welcome. Deprecated message could be removed along with this pr. |
f654efb
to
6e3be70
Compare
As a start, I moved the backup generation code to serverside. In the process, I discovered that
In the process I ended up refactoring these, hopefully it's not too big of a change |
I think your direction is correct. It would be better to do this on server side. |
da1c2e2
to
411e104
Compare
Functionality should be complete now, but such a big change I guess should have some tests added. Basically I think having the entire application logic (particularly serialization and deserialization of data) in the So I tried to move most of the database logic that I needed to the IMO if we want to support an HTTP API in the future we may want to rethink this design. |
411e104
to
c5942bb
Compare
Not sure how to proceed, writing backend only test seems more difficult than expected. Don't know how to initialize the server properly in the test. |
6ccbad5
to
dcf8028
Compare
6fd269c
to
c55c674
Compare
c55c674
to
73c353f
Compare
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Update the json backup to include the newer features like status pages etc.
Resolves #1500
Resolves #3543
Resolves #3078
Resolves #2426
Resolves #2015
Resolves #1897
Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots (if any)